net/handshake: Fix uninitialized local variable

chucklever · kuba-moo · commit 7afc6d0a107f · 2023-05-24T22:05:24.000-07:00
trace_handshake_cmd_done_err() simply records the pointer in @Req, so initializing it to NULL is sufficient and safe. Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Fixes: 3b3009e ("net/handshake: Create a NETLINK service for handling handshake requests") Reviewed-by: Simon Horman <simon.horman@corigine.com> Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/net/handshake/netlink.c b/net/handshake/netlink.c
@@ -157,8 +157,8 @@ int handshake_nl_accept_doit(struct sk_buff *skb, struct genl_info *info)
 int handshake_nl_done_doit(struct sk_buff *skb, struct genl_info *info)
 {
 	struct net *net = sock_net(skb->sk);
+	struct handshake_req *req = NULL;
 	struct socket *sock = NULL;
-	struct handshake_req *req;
 	int fd, status, err;
 
 	if (GENL_REQ_ATTR_CHECK(info, HANDSHAKE_A_DONE_SOCKFD))

Original file line number	Diff line number	Diff line change
`@@ -157,8 +157,8 @@ int handshake_nl_accept_doit(struct sk_buff skb, struct genl_info info)`
`157`	`157`	`int handshake_nl_done_doit(struct sk_buff skb, struct genl_info info)`
`158`	`158`	`{`
`159`	`159`	`struct net *net = sock_net(skb->sk);`
	`160`	`+ struct handshake_req *req = NULL;`
`160`	`161`	`struct socket *sock = NULL;`
`161`		`- struct handshake_req *req;`
`162`	`162`	`int fd, status, err;`
`163`	`163`
`164`	`164`	`if (GENL_REQ_ATTR_CHECK(info, HANDSHAKE_A_DONE_SOCKFD))`