Skip to content

Commit 2ac068c

Browse files
committed
genksyms: fix syntax error for attribute after abstact_declarator
A longstanding issue with genksyms is that it has hidden syntax errors. When a syntax error occurs, yyerror() is called. However, error_with_pos() is a no-op unless the -w option is provided. You can observe syntax errors by manually passing the -w option. For example, with CONFIG_MODVERSIONS=y on v6.13-rc1: $ make -s KCFLAGS=-D__GENKSYMS__ kernel/module/main.i $ cat kernel/module/main.i | scripts/genksyms/genksyms -w [ snip ] kernel/module/main.c:97: syntax error The syntax error occurs in the following code in kernel/module/main.c: static void __mod_update_bounds(enum mod_mem_type type __maybe_unused, void *base, unsigned int size, struct mod_tree_root *tree) { [ snip ] } The issue arises from __maybe_unused, which is defined as __attribute__((__unused__)). This commit allows direct_abstract_declarator to be followed with attributes. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Acked-by: Nicolas Schier <n.schier@avm.de>
1 parent a8b7d06 commit 2ac068c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

scripts/genksyms/parse.y

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -383,8 +383,8 @@ abstract_declarator:
383383
ptr_operator
384384
| ptr_operator abstract_declarator
385385
{ $$ = $2 ? $2 : $1; }
386-
| direct_abstract_declarator
387-
{ $$ = $1; dont_want_type_specifier = false; }
386+
| direct_abstract_declarator attribute_opt
387+
{ $$ = $2; dont_want_type_specifier = false; }
388388
;
389389

390390
direct_abstract_declarator:

0 commit comments

Comments
 (0)