Skip to content

Commit 259b363

Browse files
liulangrenaaatorvalds
authored andcommitted
mm/oom_kill: change comment and rename is_dump_unreclaim_slabs()
Change the comment of is_dump_unreclaim_slabs(), it just check whether nr_unreclaimable slabs amount is greater than user memory, and explain why we dump unreclaim slabs. Rename it to should_dump_unreclaim_slab() maybe better. Link: https://lkml.kernel.org/r/20201030182704.GA53949@rlk Signed-off-by: Hui Su <sh_def@163.com> Acked-by: Michal Hocko <mhocko@suse.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 2271b01 commit 259b363

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

mm/oom_kill.c

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -170,11 +170,13 @@ static bool oom_unkillable_task(struct task_struct *p)
170170
return false;
171171
}
172172

173-
/*
174-
* Print out unreclaimble slabs info when unreclaimable slabs amount is greater
175-
* than all user memory (LRU pages)
176-
*/
177-
static bool is_dump_unreclaim_slabs(void)
173+
/**
174+
* Check whether unreclaimable slab amount is greater than
175+
* all user memory(LRU pages).
176+
* dump_unreclaimable_slab() could help in the case that
177+
* oom due to too much unreclaimable slab used by kernel.
178+
*/
179+
static bool should_dump_unreclaim_slab(void)
178180
{
179181
unsigned long nr_lru;
180182

@@ -463,7 +465,7 @@ static void dump_header(struct oom_control *oc, struct task_struct *p)
463465
mem_cgroup_print_oom_meminfo(oc->memcg);
464466
else {
465467
show_mem(SHOW_MEM_FILTER_NODES, oc->nodemask);
466-
if (is_dump_unreclaim_slabs())
468+
if (should_dump_unreclaim_slab())
467469
dump_unreclaimable_slab();
468470
}
469471
if (sysctl_oom_dump_tasks)

0 commit comments

Comments
 (0)