Skip to content

Commit 249cc86

Browse files
lizf-oshtejun
authored andcommitted
cpuset: remove cpuset_test_cpumask()
The test is done in set_cpus_allowed_ptr(), so it's redundant. Signed-off-by: Li Zefan <lizefan@huawei.com> Signed-off-by: Tejun Heo <tj@kernel.org>
1 parent 67bd2c5 commit 249cc86

File tree

1 file changed

+1
-18
lines changed

1 file changed

+1
-18
lines changed

kernel/cpuset.c

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -783,23 +783,6 @@ void rebuild_sched_domains(void)
783783
mutex_unlock(&cpuset_mutex);
784784
}
785785

786-
/**
787-
* cpuset_test_cpumask - test a task's cpus_allowed versus its cpuset's
788-
* @tsk: task to test
789-
* @scan: struct cgroup_scanner contained in its struct cpuset_hotplug_scanner
790-
*
791-
* Call with cpuset_mutex held. May take callback_mutex during call.
792-
* Called for each task in a cgroup by cgroup_scan_tasks().
793-
* Return nonzero if this tasks's cpus_allowed mask should be changed (in other
794-
* words, if its mask is not equal to its cpuset's mask).
795-
*/
796-
static int cpuset_test_cpumask(struct task_struct *tsk,
797-
struct cgroup_scanner *scan)
798-
{
799-
return !cpumask_equal(&tsk->cpus_allowed,
800-
(cgroup_cs(scan->cg))->cpus_allowed);
801-
}
802-
803786
/**
804787
* cpuset_change_cpumask - make a task's cpus_allowed the same as its cpuset's
805788
* @tsk: task to test
@@ -835,7 +818,7 @@ static void update_tasks_cpumask(struct cpuset *cs, struct ptr_heap *heap)
835818
struct cgroup_scanner scan;
836819

837820
scan.cg = cs->css.cgroup;
838-
scan.test_task = cpuset_test_cpumask;
821+
scan.test_task = NULL;
839822
scan.process_task = cpuset_change_cpumask;
840823
scan.heap = heap;
841824
cgroup_scan_tasks(&scan);

0 commit comments

Comments
 (0)