Skip to content

DLPX-93326 Add package containing rust source files #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

prakashsurya
Copy link
Contributor

@prakashsurya prakashsurya commented Feb 7, 2025

Problem:

The linux kernel on new versions of Ubuntu requires rust source files to build, but we don't currently provide a package to distribute those source files on an appliance.

Solution:

This PR adds a new "delphix-rust-src" package that contains the rust source files that match the "delphix-rust" binary package.

Testing

  • Built the package via automation, verified both packages built and uploaded:
$ aws s3 ls s3://dev-de-images/builds/jenkins-selfservice/linux-pkg/develop/build-package/delphix-rust/pre-push/39/
2025-02-07 23:45:47        154 BUILD_INFO
2025-02-07 23:45:47         41 GIT_HASH
2025-02-07 23:45:47         64 PACKAGE_MIRROR_URL_MAIN
2025-02-07 23:45:47         62 PACKAGE_MIRROR_URL_SECONDARY
2025-02-07 23:45:47        583 SHA256SUMS
2025-02-07 23:45:47  473107120 delphix-rust-src_1.0.0-1delphix.2025.02.07.22.58_amd64.deb
2025-02-07 23:45:48  224471420 delphix-rust_1.0.0-1delphix.2025.02.07.22.58_amd64.deb
  • Downloaded and installed both packages on a DE:
$ sudo apt-get install ./delphix-rust-src_1.0.0-1delphix.2025.02.07.22.58_amd64.deb ./delphix-rust_1.0.0-1delphix.2025.02.07.22.58_amd64.deb
Reading package lists... Done
Building dependency tree
Reading state information... Done
Note, selecting 'delphix-rust-src' instead of './delphix-rust-src_1.0.0-1delphix.2025.02.07.22.58_amd64.deb'
Note, selecting 'delphix-rust' instead of './delphix-rust_1.0.0-1delphix.2025.02.07.22.58_amd64.deb'
The following NEW packages will be installed:
  delphix-rust-src
The following packages will be upgraded:
  delphix-rust
1 upgraded, 1 newly installed, 0 to remove and 9 not upgraded.
Need to get 0 B/698 MB of archives.
After this operation, 4,250 MB of additional disk space will be used.
...
Preparing to unpack .../delphix-rust_1.0.0-1delphix.2025.02.07.22.58_amd64.deb ...
Unpacking delphix-rust (1.0.0-1delphix.2025.02.07.22.58) over (1.0.0-1delphix.2025.02.05.22.33) ...
Selecting previously unselected package delphix-rust-src.
Preparing to unpack .../delphix-rust-src_1.0.0-1delphix.2025.02.07.22.58_amd64.deb ...
Unpacking delphix-rust-src (1.0.0-1delphix.2025.02.07.22.58) ...
...
  • Verified the contents of both packages after install:
$ dpkg -L delphix-rust | head -n20
/.
/usr
/usr/bin
/usr/bin/cargo
/usr/bin/cargo-clippy
/usr/bin/cargo-fmt
/usr/bin/clippy-driver
/usr/bin/rls
/usr/bin/rust-analyzer
/usr/bin/rust-gdb
/usr/bin/rust-gdbgui
/usr/bin/rust-lldb
/usr/bin/rustc
/usr/bin/rustdoc
/usr/bin/rustfmt
/usr/etc
/usr/etc/bash_completion.d
/usr/etc/bash_completion.d/cargo
/usr/lib
/usr/lib/libLLVM-19-rust-1.84.1-stable.so
$ dpkg -L delphix-rust-src | head -n20
/.
/usr
/usr/share
/usr/share/doc
/usr/share/doc/delphix-rust-src
/usr/share/doc/delphix-rust-src/changelog.Debian.gz
/usr/share/doc/delphix-rust-src/copyright
/usr/src
/usr/src/rustc-1.84.1
/usr/src/rustc-1.84.1/.cargo
/usr/src/rustc-1.84.1/.cargo/config.toml
/usr/src/rustc-1.84.1/.gitmodules
/usr/src/rustc-1.84.1/CONTRIBUTING.md
/usr/src/rustc-1.84.1/COPYRIGHT
/usr/src/rustc-1.84.1/Cargo.lock
/usr/src/rustc-1.84.1/Cargo.toml
/usr/src/rustc-1.84.1/LICENSE-APACHE
/usr/src/rustc-1.84.1/LICENSE-MIT
/usr/src/rustc-1.84.1/README.md
/usr/src/rustc-1.84.1/RELEASES.md

@prakashsurya prakashsurya force-pushed the dlpx/pr/prakashsurya/44d81f4d-b756-469c-8b67-3aa75ce85705 branch 4 times, most recently from 69e6c79 to 141e120 Compare February 7, 2025 21:50
@prakashsurya prakashsurya changed the title DLPX-XXXX Add package containing rust source files DLPX-93326 Add package containing rust source files Feb 7, 2025
@prakashsurya prakashsurya force-pushed the dlpx/pr/prakashsurya/44d81f4d-b756-469c-8b67-3aa75ce85705 branch 4 times, most recently from f7ca671 to cb97b13 Compare February 7, 2025 22:19
@prakashsurya prakashsurya marked this pull request as ready for review February 7, 2025 22:40
@prakashsurya prakashsurya force-pushed the dlpx/pr/prakashsurya/44d81f4d-b756-469c-8b67-3aa75ce85705 branch from cb97b13 to ba39688 Compare February 7, 2025 22:51
@prakashsurya prakashsurya enabled auto-merge (squash) February 8, 2025 16:50
Copy link

@tonynguien tonynguien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@prakashsurya prakashsurya merged commit 1a22454 into develop Feb 8, 2025
6 checks passed
@prakashsurya prakashsurya deleted the dlpx/pr/prakashsurya/44d81f4d-b756-469c-8b67-3aa75ce85705 branch February 8, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants