Skip to content

DLPX-74315 Conflicts between GCP agent packages #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

grwilson
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build was run locally and any changes were pushed
  • Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@grwilson
Copy link
Contributor Author

ab-pre-push: http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/appliance-build-orchestrator-pre-push/4926/

The deployed image:

root@gwilson-gcpfix:~# apt list --installed google*
Listing... Done
google-compute-engine/now 20201222.00-0ubuntu2~18.04.0 all [installed,local]
google-compute-engine-oslogin/now 20210122.00-0ubuntu1~18.04.0 amd64 [installed,local]
google-guest-agent/now 20201217.02-0ubuntu1~18.04.0 amd64 [installed,local]

@pzakha
Copy link
Contributor

pzakha commented Mar 12, 2021

Have you tested this with our current/latest linux-package-mirror on master? I.e. will it require a flag day where we need to post this review and update the mirror at the same time?

Also, can you run ab-pre-push with integration tests & upgrade tests?

@grwilson
Copy link
Contributor Author

Have you tested this with our current/latest linux-package-mirror on master? I.e. will it require a flag day where we need to post this review and update the mirror at the same time?

Also, can you run ab-pre-push with integration tests & upgrade tests?

Yes, I ran it with the current mirror and it fails to build: http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/appliance-build-orchestrator-pre-push/4927/

So we will need to update the mirror and then push this change.

I kicked off a testing build with the mirror in the bug and testing enabled: http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/appliance-build-orchestrator-pre-push/4929/

Copy link
Contributor

@pzakha pzakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending testing and an update of the mirror on master.

@grwilson
Copy link
Contributor Author

Spoke with Garrett and our plan will be as follows:

  • manually update master's mirror
  • integrate this change
  • manually update 6.0/stage mirror
  • integrate the backport
  • and finally revert the devops change to re-enable mirror syncs.

@grwilson grwilson merged commit 90a1522 into delphix:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants