DLPX-73229 iSCSI initiator name should be unique on each engine

Author: Don Brady

debian/postinst

@@ -1,6 +1,6 @@
 #!/bin/bash -eux
 #
-# Copyright 2018, 2019 Delphix
+# Copyright 2018, 2021 Delphix
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -51,6 +51,7 @@ configure)
 	systemctl enable delphix.target
 	systemctl enable delphix-platform.service
 	systemctl enable systemd-networkd.service
+	systemctl enable iscsi-name-init.service
 
 	if ! id -u postgres >/dev/null; then
 		# When installing postgres, a postgres user is created unless it

files/common/lib/open-iscsi/unique-name-check.sh

@@ -0,0 +1,55 @@
+#!/bin/bash
+#
+# Copyright (c) 2021 by Delphix. All rights reserved.
+#
+
+#
+# This script generates a unique initiator name based on the Delphix Engine UUID
+#
+
+PATH=/bin
+
+EIDFILE="/etc/engine-uuid"
+BOSMGMT="/opt/delphix/server/bin/bos_mgmt"
+NAMEFILE="/etc/iscsi/initiatorname.iscsi"
+AUTHORITY="2008-07.com.delphix"
+
+#
+# Consult bos_mgmt, if available, since it will return the updated Engine UUID
+# after a VM is cloned whereas '/etc/engine-uuid' isn't updated until after the
+# management stack is started.
+#
+if [[ -f $BOSMGMT ]]; then
+	ENGINEID=$($BOSMGMT get_system_uuid appliance)
+elif [[ -f $EIDFILE ]]; then
+	ENGINEID=$(<$EIDFILE)
+else
+	exit 0
+fi
+
+if [[ -f $NAMEFILE ]]; then
+	if [[ ${#ENGINEID} -ne 36 ]]; then
+		echo "Error: unexpected UUID -- $ENGINEID" >&2
+		exit 1
+	fi
+
+	NAMEENTRY="InitiatorName=iqn.$AUTHORITY:$ENGINEID"
+
+	#
+	# Generate IQN for this Delphix Engine (if not already present)
+	#
+	if ! grep -Gq "^$NAMEENTRY" $NAMEFILE; then
+		{
+			echo "## DO NOT EDIT OR REMOVE THIS FILE!"
+			echo "## If you remove this file, the iSCSI daemon will not start."
+			echo "## If you change the InitiatorName, existing access control lists"
+			echo "## may reject this initiator.  The InitiatorName must be unique"
+			echo "## for each iSCSI initiator.  Do NOT duplicate iSCSI InitiatorNames."
+			printf '%s\n' "$NAMEENTRY"
+		} >$NAMEFILE
+		chmod 640 $NAMEFILE
+		echo "Generating unique iSCSI name for engine $ENGINEID"
+	fi
+fi
+
+exit 0

files/common/lib/systemd/system/iscsi-name-init.service

@@ -0,0 +1,27 @@
+#
+# Copyright 2021 Delphix
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+[Unit]
+Description=One time IQN configuration for iscsid.service
+Before=open-iscsi.service
+
+[Service]
+Type=oneshot
+RemainAfterExit=no
+ExecStart=/lib/open-iscsi/unique-name-check.sh
+
+[Install]
+WantedBy=open-iscsi.service