-
Notifications
You must be signed in to change notification settings - Fork 5
Release/0.9.5 #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/0.9.5 #134
Conversation
Basic Login form
Release/0.9.0
…ement into feature/userAuth
Added 'Enter Key press event' for adding an instance
updated dependencies
…ement into feature/userAuth
…nter" and "origin/feature/informationCenter"
removed whitespace
Feature/user auth
Feature/information center
Feature/checks if user is an admin
removed some unneeded logs
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
========================================
- Coverage 4.34% 0% -4.35%
========================================
Files 12 13 +1
Lines 230 16 -214
Branches 16 2 -14
========================================
- Hits 10 0 -10
+ Misses 220 16 -204
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have looked into IRController, Authentication and ApiRoutes. Basically Scala Play Code. Everything seems good to go..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just went through all the planned functionality for this milestone and everything is working fine.
This pull requests contains all features listed in https://github.com/delphi-hub/delphi-management/milestone/2
The main feature to be added here is the user authorization needed to access the application.
@ishwaryaPaderborn and @Ayybeeshafi I assigned you two as reviewers since you helped implementing the main feature of this milestone.