Skip to content

Release/0.9.5 #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 100 commits into from
Mar 18, 2019
Merged

Release/0.9.5 #134

merged 100 commits into from
Mar 18, 2019

Conversation

janniclas
Copy link
Contributor

This pull requests contains all features listed in https://github.com/delphi-hub/delphi-management/milestone/2

The main feature to be added here is the user authorization needed to access the application.

@ishwaryaPaderborn and @Ayybeeshafi I assigned you two as reviewers since you helped implementing the main feature of this milestone.

Ayybeeshafi and others added 30 commits February 16, 2019 19:24
Basic Login form
Added 'Enter Key press event' for adding an instance
@ghost ghost assigned janniclas Mar 17, 2019
@ghost ghost added the review label Mar 17, 2019
@codecov-io
Copy link

Codecov Report

Merging #134 into master will decrease coverage by 4.34%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #134      +/-   ##
========================================
- Coverage    4.34%     0%   -4.35%     
========================================
  Files          12     13       +1     
  Lines         230     16     -214     
  Branches       16      2      -14     
========================================
- Hits           10      0      -10     
+ Misses        220     16     -204
Impacted Files Coverage Δ
app/controllers/ApiRouter.scala 0% <0%> (ø) ⬆️
app/controllers/SystemInfoController.scala 0% <0%> (-90.91%) ⬇️
app/authorization/AuthAction.scala 0% <0%> (ø)
app/authorization/AuthProvider.scala 0% <0%> (ø) ⬆️
app/controllers/InstanceRegistryController.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48b84a6...cd8b8f8. Read the comment docs.

Copy link
Contributor

@Ayybeeshafi Ayybeeshafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have looked into IRController, Authentication and ApiRoutes. Basically Scala Play Code. Everything seems good to go..

Copy link
Contributor

@ishwaryamamidi ishwaryamamidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just went through all the planned functionality for this milestone and everything is working fine.

@janniclas janniclas merged commit 7896c7a into master Mar 18, 2019
@ghost ghost removed the review label Mar 18, 2019
@janniclas janniclas deleted the release/0.9.5 branch March 26, 2019 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants