[SDEV-1916] fix pre calibration failure stops the acquisition #2985
Conversation
nandishjpatel
force-pushed
the
SDEV-1916-fix-pre-calibration-failure-stops-the-acquisition
branch
3 times, most recently
from
a7b88e5 to
842a560
Compare
|
@nandishjpatel can you resolve the conflicts in this PR? |
Updates: - The status text in the ROA window of the project tree will show "Open", "Skipped", "Failed" and respective colour - Added autostigmation and autofocus period in the Acquisition panel; previously it was in the acquisition.config file - Added a checkbox `Stop acquisition on failure` which helps is skipping roa acquisition in case of failure
nandishjpatel
force-pushed
the
SDEV-1916-fix-pre-calibration-failure-stops-the-acquisition
branch
from
842a560 to
47b50d7
Compare
Done :) |
| @@ -84,6 +84,11 @@ | |||
| } | |||
|
|
|||
|
|
|||
| class ROASkipped(Exception): | |||
| def __init__(self, message): | |||
| super().__init__(message) | |||
There was a problem hiding this comment.
can you log why the ROA is skipped?
There was a problem hiding this comment.
Agree, will add the reason to the message and then log it as well
src/odemis/acq/fastem.py
Outdated
| exc_info=True) | ||
| exception = ex # let the caller handle the exception | ||
| else: | ||
| exception = ROASkipped(f"Skipped the ROA {self._roa.shape.name.value}") |
There was a problem hiding this comment.
Why did you decide to return the ROASkipped exception and not deal with it similar to how we deal with CancelledError?
There was a problem hiding this comment.
All ROAs ProgressiveFuture are run in a ProgressiveBatchFuture. If any ProgressiveFuture raises an exception inside the ProgressiveBatchFuture all subsequent ProgressiveFuture will be cancelled. That's why I don't raise the ROASkipped and just return it to be later handled for the project tree status.
See here:
odemis/src/odemis/model/_futures.py
Line 568 in 0c0ea72
NOTE: This PR depends on #2972
[feat] allow skipping roa acquisition in case of failure
Updates:
Stop acquisition on failurewhich helps is skipping roa acquisition in case of failureCancelled
Stop acquisition on failure checked (Exception is raised in autostigmation)
Stop acquisition on failure un-checked (Exception is raised in autostigmation)
