[fix] add check if tescan stage moves to the requested position otherwise… #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieleric
requested changes
Nov 25, 2024
K4rishma
force-pushed
the
tescan_driver
branch
from
17ad892 to
80d7b17
Compare
| @@ -1096,6 +1106,58 @@ def _pollXYZ(self): | |||
| except Exception: | |||
| logging.exception("Unexpected failure during XYZ polling") | |||
|
|
|||
| def _checkPosition(self, ref_pos: Dict[str, float], pos: Dict[str, float], rel: bool = False): | |||
| """ | |||
| Checks if the current stage position is equal to the given position. | |||
There was a problem hiding this comment.
Suggested change
| Checks if the current stage position is equal to the given position. | |
| Checks if the current stage position is near the given position. |
nandishjpatel
approved these changes
Dec 20, 2024
|
@pieleric it is ready to review |
K4rishma
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… raise an error
Works on simulator
Tested on hardware