Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Improve Role Variable Naming for Enhanced Clarity and Scalability #711

Open
rht-jbittner opened this issue Jul 31, 2024 · 0 comments
Labels
needs-triage Issue requires triage. type/feature-request New feature or request

Comments

@rht-jbittner
Copy link

Current Situation

In several roles within the dellemc-openmanage-ansible-modules project (e.g., idrac_attributes role), variable names lack specificity.

For instance, the variable for the iDRAC password is simply named password. This can lead to ambiguity and conflicts when working with larger inventories that include multiple roles, collections, and hosts.

Proposed Improvement

  1. Prefix Role Variables: Add a role-specific prefix (e.g., "idrac_") to all variables within a role. This immediately clarifies the context and purpose of each variable.
  2. Example Modification
dellemc.openmanage.idrac_attributes:
    idrac_ip: "{{ idrac_hostname }}"  
    idrac_user: "{{ idrac_username }}"
    idrac_password: "{{ idrac_password }}"
    idrac_port: "{{ idrac_https_port }}" 
    idrac_ca_path: "{{ idrac_ca_path | default(omit) }}"
    idrac_validate_certs: "{{ idrac_validate_certs }}"
    idrac_attributes: "{{ idrac_attributes | default(omit) }}"
    # ... (rest of the variables similarly prefixed)
@rht-jbittner rht-jbittner added needs-triage Issue requires triage. type/feature-request New feature or request labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Issue requires triage. type/feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant