Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkboxes are not reacting properly to changes #1

Open
dominicbarnes opened this issue May 16, 2015 · 3 comments
Open

Checkboxes are not reacting properly to changes #1

dominicbarnes opened this issue May 16, 2015 · 3 comments
Assignees

Comments

@dominicbarnes
Copy link
Member

In this app if I remove a checked item from the list, the checkbox for that row and the one below get into a bad state. (hard to explain precisely, better to try it out for yourself)

This is most likely a pooling issue, but since I don't have globally unique IDs for these todo items, I can't rely on using a key. Besides, a simple example like this shouldn't require a more advanced feature like that imo.

@dominicbarnes
Copy link
Member Author

Here's a gif of the bug in action:

@anthonyshort
Copy link

I'll have to take a deeper look but I'm thinking it's either pooling or we're not handling the checked attribute properly

@dominicbarnes
Copy link
Member Author

Yeah, looks like we need to add special-cases for attributes like checked and disabled.

Deku is adding checked="true" as an HTML attribute, and the raw element shows el.checked === false. Looks like we need to take those cases and set both the DOM property and the HTML attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants