Add support for Python 3.12 and drop 3.8#932
Open
karlhayek wants to merge 3 commits intodeezer:masterfrom
Open
Add support for Python 3.12 and drop 3.8#932karlhayek wants to merge 3 commits intodeezer:masterfrom
karlhayek wants to merge 3 commits intodeezer:masterfrom
Conversation
karlhayek
requested review from
Faylixe,
alreadytaikeune,
mmoussallam and
romi1502
as code owners
This was referenced Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request title
Description
This PR:
Adds support for Python 3.12, and drops support for 3.8 as it's end-of-life now
Updates Tensorflow to version 2.14.0
Uses Ruff for linting and formatting instead of black, isort, and flake8
Fixes some typos
I implemented unit test which ran successfully using
poetry run pytest tests/Code has been formatted using
poetry run black spleeterImports has been formatted using `poetry run isort spleeter``
Documentation link and external references
Please provide any info that may help us better understand your code.