Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update milvus readme with milvus lite #232

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

zc277584121
Copy link
Contributor

No description provided.

@zc277584121 zc277584121 requested a review from a team as a code owner May 10, 2024 09:16
@zc277584121
Copy link
Contributor Author

zc277584121 commented May 11, 2024

Hello @bilgeyucel , here is a synchronize with our new milvus-haystack change, which introduct the new feature of milvus-lite which is about to be released. Could you please help to review it.

@zc277584121 zc277584121 reopened this May 11, 2024
Copy link
Contributor

@bilgeyucel bilgeyucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zc277584121, I left one minor comment

```

### Usage

First, to start up a Milvus service, follow the ['Start Milvus'](https://milvus.io/docs/install_standalone-docker.md#Start-Milvus) instructions in the documentation.
By default, if you install the latest version of pymilvus, you don't need to start the milvus service manually.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give information about the latest version number here? Is it 2.4+?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is , 2.4+ is ok, 2.4.3+ is more stable

@zc277584121 zc277584121 requested a review from bilgeyucel May 22, 2024 06:57
Signed-off-by: ChengZi <chen.zhang@zilliz.com>
@zc277584121
Copy link
Contributor Author

I have updated the description, which I think is a better expression. @bilgeyucel could you please help to review it

@anakin87 anakin87 self-requested a review September 12, 2024 16:31
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples work and look good.

Thank you!

@anakin87 anakin87 merged commit 7f96c0b into deepset-ai:main Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants