Fix: Add fence.proxy.async before TMA load in combine recv phase#632
Open
elvircrn wants to merge 1 commit into
Open
Fix: Add fence.proxy.async before TMA load in combine recv phase#632elvircrn wants to merge 1 commit into
elvircrn wants to merge 1 commit into
Conversation
…rrectness for batch size > 256 on NVL72
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Correctness issues with repeated runs of combine at bath sizes higher than 256 were found and issue was reported.
An investigation was done revealing doing __ldg on the
bufferptr instead of TMA make combine produce consistent results at bach size > 256 on NVL72. A plausible explanation for this is that switching to generic proxy resolves the issue.Investigating further revealed that the local rank polls the generic proxy but then uses TMA to load data. Without
fence.proxy.async, TMA can see stale data.From https://docs.nvidia.com/cuda/parallel-thread-execution/#async-proxy:
With the fence in place, the test scripts made as part of this report correct behavior.
Fence Performance Impact
Benchmark script.