redact logs

Author: jankuca

src/notebooks/deepnote/deepnoteCellCopyHandler.ts

@@ -93,7 +93,7 @@ export class DeepnoteCellCopyHandler implements IExtensionSyncActivationService
     private async copyCellInterceptor(): Promise<void> {
         const editor = window.activeNotebookEditor;
         if (editor && editor.notebook && editor.notebook.notebookType === 'deepnote') {
-            await this.copyCellToClipboard(false);
+            await this.copyCellToClipboard({ isCut: false });
         } else {
             logger.warn('notebook.cell.copy intercepted for non-Deepnote notebook - using fallback');
         }
@@ -106,7 +106,7 @@ export class DeepnoteCellCopyHandler implements IExtensionSyncActivationService
     private async cutCellInterceptor(): Promise<void> {
         const editor = window.activeNotebookEditor;
         if (editor && editor.notebook && editor.notebook.notebookType === 'deepnote') {
-            await this.copyCellToClipboard(true);
+            await this.copyCellToClipboard({ isCut: true });
         } else {
             logger.warn('notebook.cell.cut intercepted for non-Deepnote notebook - using fallback');
         }
@@ -160,32 +160,11 @@ export class DeepnoteCellCopyHandler implements IExtensionSyncActivationService
             cellToCopy.document.languageId
         );
 
-        // Copy all metadata, but generate new ID and sortingKey
+        // Copy all metadata (ID and sortingKey will be generated by onDidChangeNotebookDocument)
         if (cellToCopy.metadata) {
             const copiedMetadata = { ...cellToCopy.metadata };
-
-            // Generate new unique ID
-            copiedMetadata.id = generateBlockId();
-
-            // Update sortingKey in pocket if it exists
-            if (copiedMetadata.__deepnotePocket) {
-                copiedMetadata.__deepnotePocket = {
-                    ...copiedMetadata.__deepnotePocket,
-                    sortingKey: generateSortingKey(insertIndex)
-                };
-            } else if (copiedMetadata.sortingKey) {
-                copiedMetadata.sortingKey = generateSortingKey(insertIndex);
-            }
-
             newCell.metadata = copiedMetadata;
-
-            logger.info(
-                `DeepnoteCellCopyHandler: Copying cell with metadata preserved: ${JSON.stringify(
-                    copiedMetadata,
-                    null,
-                    2
-                )}`
-            );
+            logger.debug('DeepnoteCellCopyHandler: Copying cell with metadata preserved');
         }
 
         // Copy outputs if present
@@ -202,7 +181,7 @@ export class DeepnoteCellCopyHandler implements IExtensionSyncActivationService
         if (success) {
             // Move selection to the new cell
             editor.selection = new NotebookRange(insertIndex, insertIndex + 1);
-            logger.info(`DeepnoteCellCopyHandler: Successfully copied cell to index ${insertIndex}`);
+            logger.debug(`DeepnoteCellCopyHandler: Successfully copied cell to index ${insertIndex}`);
         } else {
             logger.warn('DeepnoteCellCopyHandler: Failed to copy cell');
         }
@@ -237,7 +216,7 @@ export class DeepnoteCellCopyHandler implements IExtensionSyncActivationService
                 const metadata = cell.metadata || {};
 
                 // Log the metadata to see what's actually being copied
-                logger.info(`DeepnoteCellCopyHandler: Cell added with metadata: ${JSON.stringify(metadata, null, 2)}`);
+                logger.debug('DeepnoteCellCopyHandler: Cell added with metadata');
 
                 // Only process Deepnote cells (cells with type or pocket metadata)
                 if (!metadata.type && !metadata.__deepnotePocket) {
@@ -273,10 +252,8 @@ export class DeepnoteCellCopyHandler implements IExtensionSyncActivationService
                     metadata: updatedMetadata
                 });
 
-                logger.info(
-                    `DeepnoteCellCopyHandler: Updated metadata for ${
-                        metadata.type
-                    } cell at index ${cellIndex}: ${JSON.stringify(updatedMetadata, null, 2)}`
+                logger.debug(
+                    `DeepnoteCellCopyHandler: Updated metadata for ${metadata.type} cell at index ${cellIndex}`
                 );
             }
 
@@ -303,7 +280,7 @@ export class DeepnoteCellCopyHandler implements IExtensionSyncActivationService
             const success = await workspace.applyEdit(edit);
 
             if (success) {
-                logger.info(`DeepnoteCellCopyHandler: Successfully updated metadata for ${fixes.length} cell(s)`);
+                logger.debug(`DeepnoteCellCopyHandler: Successfully updated metadata for ${fixes.length} cell(s)`);
             } else {
                 logger.warn(`DeepnoteCellCopyHandler: Failed to apply metadata fixes for ${fixes.length} cell(s)`);
             }
@@ -318,7 +295,7 @@ export class DeepnoteCellCopyHandler implements IExtensionSyncActivationService
      * Copy or cut a cell to the clipboard with metadata preserved.
      * @param isCut Whether this is a cut operation (will delete the cell after copying)
      */
-    private async copyCellToClipboard(isCut: boolean): Promise<void> {
+    private async copyCellToClipboard(params: { isCut: boolean }): Promise<void> {
         const editor = window.activeNotebookEditor;
 
         if (!editor || !editor.notebook || editor.notebook.notebookType !== 'deepnote') {
@@ -345,22 +322,16 @@ export class DeepnoteCellCopyHandler implements IExtensionSyncActivationService
         const clipboardText = `${CLIPBOARD_MARKER}${JSON.stringify(clipboardData)}`;
         await env.clipboard.writeText(clipboardText);
 
-        logger.info(
-            `DeepnoteCellCopyHandler: ${isCut ? 'Cut' : 'Copied'} cell to clipboard with metadata: ${JSON.stringify(
-                clipboardData.metadata,
-                null,
-                2
-            )}`
-        );
+        logger.debug(`DeepnoteCellCopyHandler: ${params.isCut ? 'Cut' : 'Copied'} cell to clipboard with metadata`);
 
         // If this is a cut operation, delete the cell
-        if (isCut) {
+        if (params.isCut) {
             const edit = new WorkspaceEdit();
             edit.set(editor.notebook.uri, [
                 NotebookEdit.deleteCells(new NotebookRange(selection.start, selection.start + 1))
             ]);
             await workspace.applyEdit(edit);
-            logger.info(`DeepnoteCellCopyHandler: Deleted cell after cut operation`);
+            logger.debug(`DeepnoteCellCopyHandler: Deleted cell after cut operation`);
         }
     }
 
@@ -385,7 +356,7 @@ export class DeepnoteCellCopyHandler implements IExtensionSyncActivationService
 
         // Check if clipboard contains our metadata marker
         if (!clipboardText.startsWith(CLIPBOARD_MARKER)) {
-            logger.info('DeepnoteCellCopyHandler: Clipboard does not contain Deepnote cell metadata, skipping');
+            logger.debug('DeepnoteCellCopyHandler: Clipboard does not contain Deepnote cell metadata, skipping');
             return;
         }
 
@@ -397,32 +368,13 @@ export class DeepnoteCellCopyHandler implements IExtensionSyncActivationService
             // Create new cell with preserved metadata
             const newCell = new NotebookCellData(clipboardData.kind, clipboardData.value, clipboardData.languageId);
 
-            // Copy metadata but generate new ID and sortingKey
-            const copiedMetadata = { ...clipboardData.metadata };
-
-            // Generate new unique ID
-            copiedMetadata.id = generateBlockId();
-
-            // Update sortingKey in pocket if it exists
             const insertIndex = selection.start;
-            if (copiedMetadata.__deepnotePocket) {
-                copiedMetadata.__deepnotePocket = {
-                    ...copiedMetadata.__deepnotePocket,
-                    sortingKey: generateSortingKey(insertIndex)
-                };
-            } else if (copiedMetadata.sortingKey) {
-                copiedMetadata.sortingKey = generateSortingKey(insertIndex);
-            }
 
+            // Copy metadata (ID and sortingKey will be generated by onDidChangeNotebookDocument)
+            const copiedMetadata = { ...clipboardData.metadata };
             newCell.metadata = copiedMetadata;
 
-            logger.info(
-                `DeepnoteCellCopyHandler: Pasting cell with metadata preserved: ${JSON.stringify(
-                    copiedMetadata,
-                    null,
-                    2
-                )}`
-            );
+            logger.debug('DeepnoteCellCopyHandler: Copying cell with metadata preserved');
 
             // Insert the new cell
             const edit = new WorkspaceEdit();
@@ -433,7 +385,7 @@ export class DeepnoteCellCopyHandler implements IExtensionSyncActivationService
             if (success) {
                 // Move selection to the new cell
                 editor.selection = new NotebookRange(insertIndex, insertIndex + 1);
-                logger.info(`DeepnoteCellCopyHandler: Successfully pasted cell at index ${insertIndex}`);
+                logger.debug(`DeepnoteCellCopyHandler: Successfully pasted cell at index ${insertIndex}`);
             } else {
                 logger.warn('DeepnoteCellCopyHandler: Failed to paste cell');
             }