fix: convert SQL integration credentials to normalized format for toolkit

Author: jankuca

src/notebooks/deepnote/integrations/sqlIntegrationEnvironmentVariablesProvider.ts

@@ -21,26 +21,40 @@ function getSqlEnvVarName(integrationId: string): string {
 
 /**
  * Converts integration configuration to the JSON format expected by the SQL execution code.
+ * The format must match what deepnote_toolkit expects:
+ * {
+ *   "url": "sqlalchemy_connection_url",
+ *   "params": {},
+ *   "param_style": "qmark" | "format" | etc.
+ * }
  */
 function convertIntegrationConfigToJson(config: IntegrationConfig): string {
     switch (config.type) {
-        case IntegrationType.Postgres:
+        case IntegrationType.Postgres: {
+            // Build PostgreSQL connection URL
+            // Format: postgresql://username:password@host:port/database
+            const encodedUsername = encodeURIComponent(config.username);
+            const encodedPassword = encodeURIComponent(config.password);
+            const url = `postgresql://${encodedUsername}:${encodedPassword}@${config.host}:${config.port}/${config.database}`;
+
             return JSON.stringify({
-                type: 'postgres',
-                host: config.host,
-                port: config.port,
-                database: config.database,
-                username: config.username,
-                password: config.password,
-                ssl: config.ssl ?? false
+                url: url,
+                params: config.ssl ? { sslmode: 'require' } : {},
+                param_style: 'format'
             });
+        }
 
-        case IntegrationType.BigQuery:
+        case IntegrationType.BigQuery: {
+            // BigQuery uses a special URL format
             return JSON.stringify({
-                type: 'bigquery',
-                project_id: config.projectId,
-                credentials: JSON.parse(config.credentials) // Parse the JSON string to an object
+                url: 'bigquery://?user_supplied_client=true',
+                params: {
+                    project_id: config.projectId,
+                    credentials: JSON.parse(config.credentials)
+                },
+                param_style: 'format'
             });
+        }
 
         default:
             throw new Error(`Unsupported integration type: ${(config as IntegrationConfig).type}`);

src/notebooks/deepnote/integrations/sqlIntegrationEnvironmentVariablesProvider.unit.test.ts

@@ -107,15 +107,9 @@ suite('SqlIntegrationEnvironmentVariablesProvider', () => {
         // Check that the environment variable is set
         assert.property(envVars, 'SQL_MY_POSTGRES_DB');
         const credentialsJson = JSON.parse(envVars['SQL_MY_POSTGRES_DB']!);
-        assert.deepStrictEqual(credentialsJson, {
-            type: 'postgres',
-            host: 'localhost',
-            port: 5432,
-            database: 'mydb',
-            username: 'user',
-            password: 'pass',
-            ssl: true
-        });
+        assert.strictEqual(credentialsJson.url, 'postgresql://user:pass@localhost:5432/mydb');
+        assert.deepStrictEqual(credentialsJson.params, { sslmode: 'require' });
+        assert.strictEqual(credentialsJson.param_style, 'format');
     });
 
     test('Returns environment variable for BigQuery integration', async () => {
@@ -144,11 +138,12 @@ suite('SqlIntegrationEnvironmentVariablesProvider', () => {
         // Check that the environment variable is set
         assert.property(envVars, 'SQL_MY_BIGQUERY');
         const credentialsJson = JSON.parse(envVars['SQL_MY_BIGQUERY']!);
-        assert.deepStrictEqual(credentialsJson, {
-            type: 'bigquery',
+        assert.strictEqual(credentialsJson.url, 'bigquery://?user_supplied_client=true');
+        assert.deepStrictEqual(credentialsJson.params, {
             project_id: 'my-project',
             credentials: { type: 'service_account', project_id: 'my-project' }
         });
+        assert.strictEqual(credentialsJson.param_style, 'format');
     });
 
     test('Handles multiple SQL cells with same integration', async () => {