Skip to content

Commit be53cd0

Browse files
committed
unify integration type labels with web
1 parent 6dcb177 commit be53cd0

File tree

6 files changed

+18
-18
lines changed

6 files changed

+18
-18
lines changed

INTEGRATIONS_CREDENTIALS.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ The extension supports all 18 database integration types from the `@deepnote/dat
4040
- `'pgsql'` - PostgreSQL
4141
- `'mysql'` - MySQL
4242
- `'mariadb'` - MariaDB
43-
- `'alloydb'` - Google Cloud AlloyDB
43+
- `'alloydb'` - Google AlloyDB
4444
- `'clickhouse'` - ClickHouse
4545
- `'materialize'` - Materialize
4646
- `'mindsdb'` - MindsDB
@@ -51,7 +51,7 @@ The extension supports all 18 database integration types from the `@deepnote/dat
5151

5252
- `'big-query'` - Google BigQuery (service account JSON)
5353
- `'snowflake'` - Snowflake (password or key-pair auth)
54-
- `'spanner'` - Google Cloud Spanner (service account JSON)
54+
- `'spanner'` - Google Spanner (service account JSON)
5555

5656
**Cloud Databases (AWS credentials):**
5757

src/notebooks/deepnote/sqlCellStatusBarProvider.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ interface LocalQuickPickItem extends QuickPickItem {
3737
}
3838

3939
const integrationTypeLabels: Record<ConfigurableDatabaseIntegrationType, string> = {
40-
alloydb: l10n.t('AlloyDB'),
40+
alloydb: l10n.t('Google AlloyDB'),
4141
athena: l10n.t('Amazon Athena'),
42-
'big-query': l10n.t('BigQuery'),
42+
'big-query': l10n.t('Google BigQuery'),
4343
clickhouse: l10n.t('ClickHouse'),
4444
databricks: l10n.t('Databricks'),
4545
dremio: l10n.t('Dremio'),
@@ -51,7 +51,7 @@ const integrationTypeLabels: Record<ConfigurableDatabaseIntegrationType, string>
5151
pgsql: l10n.t('PostgreSQL'),
5252
redshift: l10n.t('Amazon Redshift'),
5353
snowflake: l10n.t('Snowflake'),
54-
spanner: l10n.t('Google Cloud Spanner'),
54+
spanner: l10n.t('Google Spanner'),
5555
'sql-server': l10n.t('Microsoft SQL Server'),
5656
trino: l10n.t('Trino')
5757
};

src/notebooks/deepnote/sqlCellStatusBarProvider.unit.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -996,7 +996,7 @@ suite('SqlCellStatusBarProvider', () => {
996996
assert.strictEqual(duckDbItem.label, 'DataFrame SQL (DuckDB)');
997997
});
998998

999-
test('shows BigQuery type label for BigQuery integrations', async () => {
999+
test('shows BigQuery type label for Google BigQuery integrations', async () => {
10001000
const notebookMetadata = { deepnoteProjectId: 'project-1' };
10011001
const cell = createMockCell('sql', {}, notebookMetadata);
10021002
let quickPickItems: any[] = [];
@@ -1006,7 +1006,7 @@ suite('SqlCellStatusBarProvider', () => {
10061006
integrations: [
10071007
{
10081008
id: 'bigquery-integration',
1009-
name: 'My BigQuery',
1009+
name: 'My Google BigQuery',
10101010
type: 'big-query'
10111011
}
10121012
]
@@ -1021,8 +1021,8 @@ suite('SqlCellStatusBarProvider', () => {
10211021
await switchIntegrationHandler(cell);
10221022

10231023
const bigQueryItem = quickPickItems.find((item) => item.id === 'bigquery-integration');
1024-
assert.isDefined(bigQueryItem, 'BigQuery integration should be in quick pick items');
1025-
assert.strictEqual(bigQueryItem.description, 'BigQuery');
1024+
assert.isDefined(bigQueryItem, 'Google BigQuery integration should be in quick pick items');
1025+
assert.strictEqual(bigQueryItem.description, 'Google BigQuery');
10261026
});
10271027

10281028
test('shows raw type for unknown integration types', async () => {

src/platform/common/utils/localize.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -846,9 +846,9 @@ export namespace Integrations {
846846

847847
// Integration type labels
848848
export const postgresTypeLabel = l10n.t('PostgreSQL');
849-
export const bigQueryTypeLabel = l10n.t('BigQuery');
849+
export const bigQueryTypeLabel = l10n.t('Google BigQuery');
850850
export const snowflakeTypeLabel = l10n.t('Snowflake');
851-
export const alloyDBTypeLabel = l10n.t('AlloyDB');
851+
export const alloyDBTypeLabel = l10n.t('Google AlloyDB');
852852
export const athenaTypeLabel = l10n.t('Amazon Athena');
853853
export const clickHouseTypeLabel = l10n.t('ClickHouse');
854854
export const databricksTypeLabel = l10n.t('Databricks');
@@ -860,7 +860,7 @@ export namespace Integrations {
860860
export const mySQLTypeLabel = l10n.t('MySQL');
861861
export const duckDBTypeLabel = l10n.t('DuckDB');
862862
export const redshiftTypeLabel = l10n.t('Amazon Redshift');
863-
export const spannerTypeLabel = l10n.t('Google Cloud Spanner');
863+
export const spannerTypeLabel = l10n.t('Google Spanner');
864864
export const sqlServerTypeLabel = l10n.t('Microsoft SQL Server');
865865
export const trinoTypeLabel = l10n.t('Trino');
866866

src/webviews/webview-side/integrations/IntegrationItem.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@ export interface IIntegrationItemProps {
1313
const getIntegrationTypeLabel = (type: ConfigurableDatabaseIntegrationType): string => {
1414
switch (type) {
1515
case 'alloydb':
16-
return getLocString('integrationsAlloyDBTypeLabel', 'AlloyDB');
16+
return getLocString('integrationsAlloyDBTypeLabel', 'Google AlloyDB');
1717
case 'athena':
1818
return getLocString('integrationsAthenaTypeLabel', 'Amazon Athena');
1919
case 'big-query':
20-
return getLocString('integrationsBigQueryTypeLabel', 'BigQuery');
20+
return getLocString('integrationsBigQueryTypeLabel', 'Google BigQuery');
2121
case 'clickhouse':
2222
return getLocString('integrationsClickHouseTypeLabel', 'ClickHouse');
2323
case 'databricks':
@@ -41,7 +41,7 @@ const getIntegrationTypeLabel = (type: ConfigurableDatabaseIntegrationType): str
4141
case 'snowflake':
4242
return getLocString('integrationsSnowflakeTypeLabel', 'Snowflake');
4343
case 'spanner':
44-
return getLocString('integrationsSpannerTypeLabel', 'Google Cloud Spanner');
44+
return getLocString('integrationsSpannerTypeLabel', 'Google Spanner');
4545
case 'sql-server':
4646
return getLocString('integrationsSQLServerTypeLabel', 'Microsoft SQL Server');
4747
case 'trino':

src/webviews/webview-side/integrations/integrationUtils.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ const trinoLogo: string = require('./icons/trino.svg');
2424

2525
// Localized labels for integration types (duplicated from sqlCellStatusBarProvider.ts due to import restrictions)
2626
export const integrationTypeLabels: Record<ConfigurableDatabaseIntegrationType, string> = {
27-
alloydb: 'AlloyDB',
27+
alloydb: 'Google AlloyDB',
2828
athena: 'Amazon Athena',
29-
'big-query': 'BigQuery',
29+
'big-query': 'Google BigQuery',
3030
clickhouse: 'ClickHouse',
3131
databricks: 'Databricks',
3232
dremio: 'Dremio',
@@ -38,7 +38,7 @@ export const integrationTypeLabels: Record<ConfigurableDatabaseIntegrationType,
3838
pgsql: 'PostgreSQL',
3939
redshift: 'Amazon Redshift',
4040
snowflake: 'Snowflake',
41-
spanner: 'Google Cloud Spanner',
41+
spanner: 'Google Spanner',
4242
'sql-server': 'Microsoft SQL Server',
4343
trino: 'Trino'
4444
};

0 commit comments

Comments
 (0)