address coderabbit feedback

Author: Artmann

src/notebooks/deepnote/converters/codeBlockConverter.ts

@@ -9,7 +9,7 @@ export class CodeBlockConverter implements BlockConverter {
     }
 
     canConvert(blockType: string): boolean {
-        return blockType === 'code';
+        return blockType.toLowerCase() === 'code';
     }
 
     convertToCell(block: DeepnoteBlock): NotebookCellData {

src/notebooks/deepnote/converters/codeBlockConverter.unit.test.ts

@@ -16,6 +16,12 @@ suite('CodeBlockConverter', () => {
             assert.isTrue(converter.canConvert('code'));
         });
 
+        test('canConvert ignores case', () => {
+            assert.isTrue(converter.canConvert('CODE'));
+            assert.isTrue(converter.canConvert('Code'));
+            assert.isTrue(converter.canConvert('CoDe'));
+        });
+
         test('returns false for non-code types', () => {
             assert.isFalse(converter.canConvert('markdown'));
             assert.isFalse(converter.canConvert('text-cell-h1'));

src/notebooks/deepnote/converters/converterRegistry.ts

@@ -1,20 +1,17 @@
 import type { BlockConverter } from './blockConverter';
 
 export class ConverterRegistry {
-    private readonly converters: BlockConverter[] = [];
     private readonly typeToConverterMap: Map<string, BlockConverter> = new Map();
 
     findConverter(blockType: string): BlockConverter | undefined {
-        return this.typeToConverterMap.get(blockType);
+        return this.typeToConverterMap.get(blockType.toLowerCase());
     }
 
     listSupportedTypes(): string[] {
         return Array.from(this.typeToConverterMap.keys()).sort();
     }
 
     register(converter: BlockConverter): void {
-        this.converters.push(converter);
-
         converter.getSupportedTypes().forEach((type) => {
             this.typeToConverterMap.set(type, converter);
         });

src/notebooks/deepnote/converters/markdownBlockConverter.ts

@@ -9,7 +9,7 @@ export class MarkdownBlockConverter implements BlockConverter {
     }
 
     canConvert(blockType: string): boolean {
-        return blockType === 'markdown';
+        return blockType.toLowerCase() === 'markdown';
     }
 
     convertToCell(block: DeepnoteBlock): NotebookCellData {

src/notebooks/deepnote/converters/markdownBlockConverter.unit.test.ts

@@ -16,6 +16,12 @@ suite('MarkdownBlockConverter', () => {
             assert.isTrue(converter.canConvert('markdown'));
         });
 
+        test('canConvert ignores case', () => {
+            assert.isTrue(converter.canConvert('MARKDOWN'));
+            assert.isTrue(converter.canConvert('Markdown'));
+            assert.isTrue(converter.canConvert('MaRkDoWn'));
+        });
+
         test('returns false for non-markdown types', () => {
             assert.isFalse(converter.canConvert('code'));
             assert.isFalse(converter.canConvert('text-cell-h1'));

src/notebooks/deepnote/converters/textBlockConverter.ts

@@ -10,11 +10,11 @@ export class TextBlockConverter implements BlockConverter {
         let value = cell.value || '';
 
         if (block.type === 'text-cell-h1') {
-            value = value.replace(/^#\s+/, '');
+            value = value.replace(/^\s*#\s+/, '');
         } else if (block.type === 'text-cell-h2') {
-            value = value.replace(/^##\s+/, '');
+            value = value.replace(/^\s*##\s+/, '');
         } else if (block.type === 'text-cell-h3') {
-            value = value.replace(/^###\s+/, '');
+            value = value.replace(/^\s*###\s+/, '');
         }
 
         block.content = value;
@@ -43,6 +43,6 @@ export class TextBlockConverter implements BlockConverter {
     }
 
     getSupportedTypes(): string[] {
-        return TextBlockConverter.textBlockTypes;
+        return [...TextBlockConverter.textBlockTypes];
     }
 }

src/notebooks/deepnote/converters/textBlockConverter.unit.test.ts

@@ -135,6 +135,20 @@ suite('TextBlockConverter', () => {
             assert.strictEqual(block.content, 'New Title');
         });
 
+        test('strips # prefix with leading whitespace from h1 cell', () => {
+            const block: DeepnoteBlock = {
+                content: 'old content',
+                id: 'block-123',
+                sortingKey: 'a0',
+                type: 'text-cell-h1'
+            };
+            const cell = new NotebookCellData(NotebookCellKind.Markup, '  # New Title', 'markdown');
+
+            converter.applyChangesToBlock(block, cell);
+
+            assert.strictEqual(block.content, 'New Title');
+        });
+
         test('strips ## prefix from h2 cell', () => {
             const block: DeepnoteBlock = {
                 content: 'old content',
@@ -149,6 +163,20 @@ suite('TextBlockConverter', () => {
             assert.strictEqual(block.content, 'New Section');
         });
 
+        test('strips ## prefix with leading whitespace from h2 cell', () => {
+            const block: DeepnoteBlock = {
+                content: 'old content',
+                id: 'block-123',
+                sortingKey: 'a0',
+                type: 'text-cell-h2'
+            };
+            const cell = new NotebookCellData(NotebookCellKind.Markup, '   ## New Section', 'markdown');
+
+            converter.applyChangesToBlock(block, cell);
+
+            assert.strictEqual(block.content, 'New Section');
+        });
+
         test('strips ### prefix from h3 cell', () => {
             const block: DeepnoteBlock = {
                 content: 'old content',
@@ -163,6 +191,20 @@ suite('TextBlockConverter', () => {
             assert.strictEqual(block.content, 'New Subsection');
         });
 
+        test('strips ### prefix with leading whitespace from h3 cell', () => {
+            const block: DeepnoteBlock = {
+                content: 'old content',
+                id: 'block-123',
+                sortingKey: 'a0',
+                type: 'text-cell-h3'
+            };
+            const cell = new NotebookCellData(NotebookCellKind.Markup, '\t### New Subsection', 'markdown');
+
+            converter.applyChangesToBlock(block, cell);
+
+            assert.strictEqual(block.content, 'New Subsection');
+        });
+
         test('does not strip prefix from paragraph cell', () => {
             const block: DeepnoteBlock = {
                 content: 'old content',

src/notebooks/deepnote/deepnoteTypes.ts

@@ -34,6 +34,7 @@ export interface DeepnoteNotebook {
  * Can be either a code block or a markdown block.
  */
 export interface DeepnoteBlock {
+    blockGroup?: string;
     content: string;
     executionCount?: number;
     id: string;

src/notebooks/deepnote/pocket.ts

@@ -3,7 +3,7 @@ import type { NotebookCellData } from 'vscode';
 import type { DeepnoteBlock, DeepnoteOutput } from './deepnoteTypes';
 import { generateBlockId, generateSortingKey } from './dataConversionUtils';
 
-const deepnoteBlockSpecificFields: string[] = ['blockGroup', 'executionCount', 'id', 'outputs', 'sortingKey', 'type'];
+const deepnoteBlockSpecificFields = ['blockGroup', 'executionCount', 'id', 'outputs', 'sortingKey', 'type'] as const;
 
 // Stores extra Deepnote-specific fields for each block that are not part of the standard VSCode NotebookCellData structure.
 export interface Pocket {
@@ -53,7 +53,7 @@ export function createBlockFromPocket(cell: NotebookCellData, index: number): De
     }
 
     const block: DeepnoteBlock = {
-        content: '',
+        content: cell.value,
         id: pocket?.id || generateBlockId(),
         metadata,
         sortingKey: pocket?.sortingKey || generateSortingKey(index),
@@ -62,7 +62,7 @@ export function createBlockFromPocket(cell: NotebookCellData, index: number): De
 
     // Only add optional fields if they exist
     if (pocket?.blockGroup) {
-        (block as DeepnoteBlock & { blockGroup?: string }).blockGroup = pocket.blockGroup;
+        block.blockGroup = pocket.blockGroup;
     }
 
     if (pocket?.executionCount !== undefined) {

src/notebooks/deepnote/serialization.md

@@ -32,7 +32,7 @@ Converters are registered in a `ConverterRegistry` and retrieved based on block
 
 When opening a Deepnote notebook in VS Code:
 
-```
+```text
 Deepnote YAML File
     ↓
 Parse YAML (js-yaml)
@@ -58,7 +58,7 @@ VS Code NotebookData with cells
 
 When saving a notebook in VS Code:
 
-```
+```text
 VS Code NotebookData with cells
     ↓
 For each cell:
@@ -225,13 +225,15 @@ test('my-block-type round-trips correctly', () => {
 ## Important Guidelines
 
 ### DO:
+
 - ✅ Use the pocket system for Deepnote-specific fields
 - ✅ Preserve all block metadata during conversion
 - ✅ Test round-trip conversion (blocks → cells → blocks)
 - ✅ Handle both empty and undefined fields correctly
 - ✅ Use `assert.deepStrictEqual()` for object comparisons in tests
 
 ### DON'T:
+
 - ❌ Store Deepnote-specific data directly in cell metadata (use the pocket)
 - ❌ Modify the pocket in converters (it's managed automatically)
 - ❌ Assume all optional fields exist (check for undefined)