drop extra localization parsing roundtrip

Author: jankuca

src/notebooks/deepnote/integrations/integrationWebview.ts

@@ -141,7 +141,7 @@ export class IntegrationWebviewProvider implements IIntegrationWebviewProvider {
 
         await this.currentPanel.webview.postMessage({
             type: SharedMessages.LocInit,
-            locStrings: JSON.stringify(locStrings)
+            locStrings: locStrings
         });
     }
 

src/platform/webviews/webviewHost.ts

@@ -221,7 +221,7 @@ export abstract class WebviewHost<IMapping> implements IDisposable {
     }
 
     protected async sendLocStrings() {
-        const locStrings: LocalizedMessages = {
+        const locStrings: Partial<LocalizedMessages> = {
             collapseSingle: localize.WebViews.collapseSingle,
             expandSingle: localize.WebViews.expandSingle,
             openExportFileYes: localize.DataScience.openExportFileYes,
@@ -265,43 +265,7 @@ export abstract class WebviewHost<IMapping> implements IDisposable {
             dataframeNextPage: localize.WebViews.dataframeNextPage,
             dataframePageOf: localize.WebViews.dataframePageOf,
             dataframeCopyTable: localize.WebViews.dataframeCopyTable,
-            dataframeExportTable: localize.WebViews.dataframeExportTable,
-            // Integration panel strings (not used in this webview, but required by type)
-            integrationsTitle: '',
-            integrationsNoIntegrationsFound: '',
-            integrationsConnected: '',
-            integrationsNotConfigured: '',
-            integrationsConfigure: '',
-            integrationsReconfigure: '',
-            integrationsReset: '',
-            integrationsConfirmResetTitle: '',
-            integrationsConfirmResetMessage: '',
-            integrationsConfirmResetDetails: '',
-            integrationsConfigureTitle: '',
-            integrationsCancel: '',
-            integrationsSave: '',
-            integrationsPostgresNameLabel: '',
-            integrationsPostgresNamePlaceholder: '',
-            integrationsPostgresHostLabel: '',
-            integrationsPostgresHostPlaceholder: '',
-            integrationsPostgresPortLabel: '',
-            integrationsPostgresPortPlaceholder: '',
-            integrationsPostgresDatabaseLabel: '',
-            integrationsPostgresDatabasePlaceholder: '',
-            integrationsPostgresUsernameLabel: '',
-            integrationsPostgresUsernamePlaceholder: '',
-            integrationsPostgresPasswordLabel: '',
-            integrationsPostgresPasswordPlaceholder: '',
-            integrationsPostgresSslLabel: '',
-            integrationsBigQueryNameLabel: '',
-            integrationsBigQueryNamePlaceholder: '',
-            integrationsBigQueryProjectIdLabel: '',
-            integrationsBigQueryProjectIdPlaceholder: '',
-            integrationsBigQueryCredentialsLabel: '',
-            integrationsBigQueryCredentialsPlaceholder: '',
-            integrationsBigQueryCredentialsRequired: '',
-            integrationsRequiredField: '',
-            integrationsOptionalField: ''
+            dataframeExportTable: localize.WebViews.dataframeExportTable
         };
         this.postMessageInternal(SharedMessages.LocInit, JSON.stringify(locStrings)).catch(noop);
     }

src/webviews/webview-side/integrations/IntegrationPanel.tsx

@@ -42,7 +42,7 @@ export const IntegrationPanel: React.FC<IIntegrationPanelProps> = ({ baseTheme,
             switch (msg.type) {
                 case 'loc_init':
                     if (msg.type === 'loc_init') {
-                        const locStrings = JSON.parse(msg.locStrings);
+                        const locStrings = msg.locStrings;
                         storeLocStrings(locStrings);
                     }
                     break;

src/webviews/webview-side/integrations/types.ts

@@ -56,7 +56,7 @@ export interface StatusMessage {
 
 export interface LocInitMessage {
     type: 'loc_init';
-    locStrings: string;
+    locStrings: Partial<import('../../../messageTypes').LocalizedMessages>;
 }
 
 export type WebviewMessage = UpdateMessage | ShowFormMessage | StatusMessage | LocInitMessage;

src/webviews/webview-side/react-common/locReactSide.ts

@@ -6,17 +6,17 @@ import { LocalizedMessages } from '../../../messageTypes';
 // The react code can't use the localize.ts module because it reads from
 // disk. This isn't allowed inside a browser, so we pass the collection
 // through the javascript.
-let loadedCollection: LocalizedMessages | undefined;
+let loadedCollection: Partial<LocalizedMessages> | undefined;
 
 export function getLocString(key: keyof LocalizedMessages, defValue: string): string {
     if (loadedCollection && loadedCollection.hasOwnProperty(key)) {
-        return loadedCollection[key];
+        return loadedCollection[key] ?? defValue;
     }
 
     return defValue;
 }
 
-export function storeLocStrings(collection: LocalizedMessages) {
+export function storeLocStrings(collection: Partial<LocalizedMessages>) {
     loadedCollection = collection;
 }