Skip to content

Commit 94ba87e

Browse files
committed
localize "unsupported integration type" message
1 parent 4a7c399 commit 94ba87e

File tree

4 files changed

+12
-4
lines changed

4 files changed

+12
-4
lines changed

src/messageTypes.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,7 @@ export type LocalizedMessages = {
235235
integrationsRequiredField: string;
236236
integrationsOptionalField: string;
237237
integrationsUnnamedIntegration: string;
238+
integrationsUnsupportedIntegrationType: string;
238239
// Select input settings strings
239240
selectInputSettingsTitle: string;
240241
allowMultipleValues: string;

src/notebooks/deepnote/integrations/integrationWebview.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,8 @@ export class IntegrationWebviewProvider implements IIntegrationWebviewProvider {
177177
integrationsSnowflakeRolePlaceholder: localize.Integrations.snowflakeRolePlaceholder,
178178
integrationsSnowflakeWarehouseLabel: localize.Integrations.snowflakeWarehouseLabel,
179179
integrationsSnowflakeWarehousePlaceholder: localize.Integrations.snowflakeWarehousePlaceholder,
180-
integrationsUnnamedIntegration: localize.Integrations.unnamedIntegration('{0}')
180+
integrationsUnnamedIntegration: localize.Integrations.unnamedIntegration('{0}'),
181+
integrationsUnsupportedIntegrationType: localize.Integrations.unsupportedIntegrationType('{0}')
181182
};
182183

183184
await this.currentPanel.webview.postMessage({

src/platform/common/utils/localize.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -831,6 +831,7 @@ export namespace Integrations {
831831
export const requiredField = l10n.t('*');
832832
export const optionalField = l10n.t('(optional)');
833833
export const unnamedIntegration = (id: string) => l10n.t('Unnamed Integration ({0})', id);
834+
export const unsupportedIntegrationType = (type: string) => l10n.t('Unsupported integration type: {0}', type);
834835

835836
// Integration type labels
836837
export const postgresTypeLabel = l10n.t('PostgreSQL');

src/webviews/webview-side/integrations/ConfigurationForm.tsx

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import * as React from 'react';
2-
import { getLocString } from '../react-common/locReactSide';
2+
import { format, getLocString } from '../react-common/locReactSide';
33
import { PostgresForm } from './PostgresForm';
44
import { BigQueryForm } from './BigQueryForm';
55
import { SnowflakeForm } from './SnowflakeForm';
@@ -70,8 +70,13 @@ export const ConfigurationForm: React.FC<IConfigurationFormProps> = ({
7070
onCancel={onCancel}
7171
/>
7272
);
73-
default:
74-
return <div>Unsupported integration type: {integrationType}</div>;
73+
default: {
74+
const unsupportedMessage = getLocString(
75+
'integrationsUnsupportedIntegrationType',
76+
'Unsupported integration type: {0}'
77+
);
78+
return <div>{format(unsupportedMessage, integrationType)}</div>;
79+
}
7580
}
7681
})()}
7782
</div>

0 commit comments

Comments
 (0)