better errrors

Author: Artmann

src/notebooks/deepnote/deepnoteNotebookCommandListener.ts

@@ -17,6 +17,7 @@ import { IExtensionSyncActivationService } from '../../platform/activation/types
 import { IDisposableRegistry } from '../../platform/common/types';
 import { Commands } from '../../platform/common/constants';
 import { chainWithPendingUpdates } from '../../kernels/execution/notebookUpdater';
+import { WrappedError } from '../../platform/errors/types';
 import {
     DeepnoteBigNumberMetadataSchema,
     DeepnoteTextInputMetadataSchema,
@@ -269,12 +270,11 @@ export class DeepnoteNotebookCommandListener implements IExtensionSyncActivation
         const editor = window.activeNotebookEditor;
 
         if (!editor) {
-            throw new Error(l10n.t('No active notebook editor found'));
+            throw new WrappedError(l10n.t('No active notebook editor found'));
         }
 
         const document = editor.notebook;
         const selection = editor.selection;
-
         const insertIndex = selection ? selection.end : document.cellCount;
 
         const defaultVisualizationSpec = {
@@ -310,7 +310,7 @@ export class DeepnoteNotebookCommandListener implements IExtensionSyncActivation
         });
 
         if (result !== true) {
-            throw new Error(l10n.t('Failed to insert chart block'));
+            throw new WrappedError(l10n.t('Failed to insert chart block'));
         }
 
         const notebookRange = new NotebookRange(insertIndex, insertIndex + 1);

src/notebooks/deepnote/deepnoteNotebookCommandListener.unit.test.ts

@@ -21,6 +21,7 @@ import {
 import { IDisposable } from '../../platform/common/types';
 import * as notebookUpdater from '../../kernels/execution/notebookUpdater';
 import { createMockedNotebookDocument } from '../../test/datascience/editor-integration/helpers';
+import { WrappedError } from '../../platform/errors/types';
 
 suite('DeepnoteNotebookCommandListener', () => {
     let commandListener: DeepnoteNotebookCommandListener;
@@ -1138,7 +1139,11 @@ suite('DeepnoteNotebookCommandListener', () => {
                 });
 
                 // Call the method and expect rejection
-                await assert.isRejected(commandListener.addChartBlock(), Error, 'No active notebook editor found');
+                await assert.isRejected(
+                    commandListener.addChartBlock(),
+                    WrappedError,
+                    'No active notebook editor found'
+                );
             });
 
             test('should throw error when chainWithPendingUpdates fails', async () => {
@@ -1154,7 +1159,7 @@ suite('DeepnoteNotebookCommandListener', () => {
                 sandbox.stub(notebookUpdater, 'chainWithPendingUpdates').resolves(false);
 
                 // Call the method and expect rejection
-                await assert.isRejected(commandListener.addChartBlock(), Error, 'Failed to insert chart block');
+                await assert.isRejected(commandListener.addChartBlock(), WrappedError, 'Failed to insert chart block');
             });
         });
     });