replace default integration name placeholder

Author: jankuca

src/messageTypes.ts

@@ -444,6 +444,7 @@ export type LocalizedMessages = {
     integrationsRequiredField: string;
     integrationsOptionalField: string;
     integrationsUnnamedIntegration: string;
+    integrationsDefaultName: string;
     integrationsUnsupportedIntegrationType: string;
     // Select input settings strings
     selectInputSettingsTitle: string;

src/notebooks/deepnote/integrations/integrationWebview.ts

@@ -375,6 +375,7 @@ export class IntegrationWebviewProvider implements IIntegrationWebviewProvider {
             integrationsCaCertificateText: localize.Integrations.caCertificateText,
             integrationsCaCertificateTextPlaceholder: localize.Integrations.caCertificateTextPlaceholder,
             integrationsUnnamedIntegration: localize.Integrations.unnamedIntegration('{0}'),
+            integrationsDefaultName: localize.Integrations.defaultName('{0}'),
             integrationsUnsupportedIntegrationType: localize.Integrations.unsupportedIntegrationType('{0}')
         };
 

src/platform/common/utils/localize.ts

@@ -833,6 +833,7 @@ export namespace Integrations {
     export const requiredField = l10n.t('*');
     export const optionalField = l10n.t('(optional)');
     export const unnamedIntegration = (id: string) => l10n.t('Unnamed Integration ({0})', id);
+    export const defaultName = (type: string) => l10n.t('My {0} integration', type);
     export const unsupportedIntegrationType = (type: string) => l10n.t('Unsupported integration type: {0}', type);
 
     // Integration type labels

src/webviews/webview-side/integrations/AlloyDBForm.tsx

@@ -1,8 +1,9 @@
 import * as React from 'react';
-import { format, getLocString } from '../react-common/locReactSide';
+import { getLocString } from '../react-common/locReactSide';
 import { DatabaseIntegrationConfig } from '@deepnote/database-integrations';
 import { SshOptionsFields } from './SshOptionsFields';
 import { CaCertificateFields } from './CaCertificateFields';
+import { getDefaultIntegrationName } from './integrationUtils';
 
 export interface IAlloyDBFormProps {
     integrationId: string;
@@ -16,11 +17,9 @@ function createEmptyAlloyDBConfig(params: {
     id: string;
     name?: string;
 }): Extract<DatabaseIntegrationConfig, { type: 'alloydb' }> {
-    const unnamedIntegration = getLocString('integrationsUnnamedIntegration', 'Unnamed Integration ({0})');
-
     return {
         id: params.id,
-        name: (params.name || format(unnamedIntegration, params.id)).trim(),
+        name: (params.name || getDefaultIntegrationName('alloydb')).trim(),
         type: 'alloydb',
         metadata: {
             host: '',

src/webviews/webview-side/integrations/AthenaForm.tsx

@@ -1,16 +1,15 @@
 import * as React from 'react';
-import { format, getLocString } from '../react-common/locReactSide';
+import { getLocString } from '../react-common/locReactSide';
 import { DatabaseIntegrationConfig } from '@deepnote/database-integrations';
+import { getDefaultIntegrationName } from './integrationUtils';
 
 function createEmptyAthenaConfig(params: {
     id: string;
     name?: string;
 }): Extract<DatabaseIntegrationConfig, { type: 'athena' }> {
-    const unnamedIntegration = getLocString('integrationsUnnamedIntegration', 'Unnamed Integration ({0})');
-
     return {
         id: params.id,
-        name: (params.name || format(unnamedIntegration, params.id)).trim(),
+        name: (params.name || getDefaultIntegrationName('athena')).trim(),
         type: 'athena',
         metadata: {
             access_key_id: '',

src/webviews/webview-side/integrations/BigQueryForm.tsx

@@ -1,15 +1,14 @@
 import * as React from 'react';
 import { format, getLocString } from '../react-common/locReactSide';
 import { BigQueryAuthMethods, DatabaseIntegrationConfig } from '@deepnote/database-integrations';
+import { getDefaultIntegrationName } from './integrationUtils';
 
 type BigQueryConfig = Extract<DatabaseIntegrationConfig, { type: 'big-query' }>;
 
 function createEmptyBigQueryConfig(params: { id: string; name?: string }): BigQueryConfig {
-    const unnamedIntegration = getLocString('integrationsUnnamedIntegration', 'Unnamed Integration ({0})');
-
     return {
         id: params.id,
-        name: (params.name || format(unnamedIntegration, params.id)).trim(),
+        name: (params.name || getDefaultIntegrationName('big-query')).trim(),
         type: 'big-query',
         metadata: {
             authMethod: BigQueryAuthMethods.ServiceAccount,

src/webviews/webview-side/integrations/ClickHouseForm.tsx

@@ -1,8 +1,9 @@
 import * as React from 'react';
-import { format, getLocString } from '../react-common/locReactSide';
+import { getLocString } from '../react-common/locReactSide';
 import { DatabaseIntegrationConfig } from '@deepnote/database-integrations';
 import { SshOptionsFields } from './SshOptionsFields';
 import { CaCertificateFields } from './CaCertificateFields';
+import { getDefaultIntegrationName } from './integrationUtils';
 
 export interface IClickHouseFormProps {
     integrationId: string;
@@ -16,11 +17,9 @@ function createEmptyClickHouseConfig(params: {
     id: string;
     name?: string;
 }): Extract<DatabaseIntegrationConfig, { type: 'clickhouse' }> {
-    const unnamedIntegration = getLocString('integrationsUnnamedIntegration', 'Unnamed Integration ({0})');
-
     return {
         id: params.id,
-        name: (params.name || format(unnamedIntegration, params.id)).trim(),
+        name: (params.name || getDefaultIntegrationName('clickhouse')).trim(),
         type: 'clickhouse',
         metadata: {
             host: '',

src/webviews/webview-side/integrations/ConfigurationForm.tsx

@@ -18,27 +18,7 @@ import { SpannerForm } from './SpannerForm';
 import { SQLServerForm } from './SQLServerForm';
 import { TrinoForm } from './TrinoForm';
 import { ConfigurableDatabaseIntegrationConfig, ConfigurableDatabaseIntegrationType } from './types';
-
-// Localized labels for integration types (duplicated from sqlCellStatusBarProvider.ts due to import restrictions)
-const integrationTypeLabels: Record<ConfigurableDatabaseIntegrationType, string> = {
-    alloydb: 'AlloyDB',
-    athena: 'Amazon Athena',
-    'big-query': 'BigQuery',
-    clickhouse: 'ClickHouse',
-    databricks: 'Databricks',
-    dremio: 'Dremio',
-    mariadb: 'MariaDB',
-    materialize: 'Materialize',
-    mindsdb: 'MindsDB',
-    mongodb: 'MongoDB',
-    mysql: 'MySQL',
-    pgsql: 'PostgreSQL',
-    redshift: 'Amazon Redshift',
-    snowflake: 'Snowflake',
-    spanner: 'Google Cloud Spanner',
-    'sql-server': 'SQL Server',
-    trino: 'Trino'
-};
+import { integrationTypeLabels } from './integrationUtils';
 
 export interface IConfigurationFormProps {
     integrationId: string;

src/webviews/webview-side/integrations/DatabricksForm.tsx

@@ -1,17 +1,16 @@
 import * as React from 'react';
-import { format, getLocString } from '../react-common/locReactSide';
+import { getLocString } from '../react-common/locReactSide';
 import { DatabaseIntegrationConfig } from '@deepnote/database-integrations';
 import { SshOptionsFields } from './SshOptionsFields';
+import { getDefaultIntegrationName } from './integrationUtils';
 
 function createEmptyDatabricksConfig(params: {
     id: string;
     name?: string;
 }): Extract<DatabaseIntegrationConfig, { type: 'databricks' }> {
-    const unnamedIntegration = getLocString('integrationsUnnamedIntegration', 'Unnamed Integration ({0})');
-
     return {
         id: params.id,
-        name: (params.name || format(unnamedIntegration, params.id)).trim(),
+        name: (params.name || getDefaultIntegrationName('databricks')).trim(),
         type: 'databricks',
         metadata: {
             host: '',

src/webviews/webview-side/integrations/DremioForm.tsx

@@ -1,17 +1,16 @@
 import * as React from 'react';
-import { format, getLocString } from '../react-common/locReactSide';
+import { getLocString } from '../react-common/locReactSide';
 import { DatabaseIntegrationConfig } from '@deepnote/database-integrations';
 import { SshOptionsFields } from './SshOptionsFields';
+import { getDefaultIntegrationName } from './integrationUtils';
 
 function createEmptyDremioConfig(params: {
     id: string;
     name?: string;
 }): Extract<DatabaseIntegrationConfig, { type: 'dremio' }> {
-    const unnamedIntegration = getLocString('integrationsUnnamedIntegration', 'Unnamed Integration ({0})');
-
     return {
         id: params.id,
-        name: (params.name || format(unnamedIntegration, params.id)).trim(),
+        name: (params.name || getDefaultIntegrationName('dremio')).trim(),
         type: 'dremio',
         metadata: {
             host: '',