remove empty localization strings

Author: jankuca

src/messageTypes.ts

@@ -193,7 +193,6 @@ export type LocalizedMessages = {
     integrationsPostgresPasswordLabel: string;
     integrationsPostgresPasswordPlaceholder: string;
     integrationsPostgresSslLabel: string;
-    integrationsPostgresUnnamedIntegration: string;
     // BigQuery form strings
     integrationsBigQueryNameLabel: string;
     integrationsBigQueryNamePlaceholder: string;
@@ -202,8 +201,6 @@ export type LocalizedMessages = {
     integrationsBigQueryCredentialsLabel: string;
     integrationsBigQueryCredentialsPlaceholder: string;
     integrationsBigQueryCredentialsRequired: string;
-    integrationsBigQueryInvalidJson: string;
-    integrationsBigQueryUnnamedIntegration: string;
     // Common form strings
     integrationsRequiredField: string;
     integrationsOptionalField: string;

src/notebooks/deepnote/integrations/integrationWebview.ts

@@ -130,16 +130,13 @@ export class IntegrationWebviewProvider implements IIntegrationWebviewProvider {
             integrationsPostgresPasswordLabel: localize.Integrations.postgresPasswordLabel,
             integrationsPostgresPasswordPlaceholder: localize.Integrations.postgresPasswordPlaceholder,
             integrationsPostgresSslLabel: localize.Integrations.postgresSslLabel,
-            integrationsPostgresUnnamedIntegration: '', // Will be formatted on the client side
             integrationsBigQueryNameLabel: localize.Integrations.bigQueryNameLabel,
             integrationsBigQueryNamePlaceholder: localize.Integrations.bigQueryNamePlaceholder,
             integrationsBigQueryProjectIdLabel: localize.Integrations.bigQueryProjectIdLabel,
             integrationsBigQueryProjectIdPlaceholder: localize.Integrations.bigQueryProjectIdPlaceholder,
             integrationsBigQueryCredentialsLabel: localize.Integrations.bigQueryCredentialsLabel,
             integrationsBigQueryCredentialsPlaceholder: localize.Integrations.bigQueryCredentialsPlaceholder,
-            integrationsBigQueryCredentialsRequired: localize.Integrations.bigQueryCredentialsRequired,
-            integrationsBigQueryInvalidJson: '', // Will be formatted on the client side
-            integrationsBigQueryUnnamedIntegration: '' // Will be formatted on the client side
+            integrationsBigQueryCredentialsRequired: localize.Integrations.bigQueryCredentialsRequired
         };
 
         await this.currentPanel.webview.postMessage({

src/platform/webviews/webviewHost.ts

@@ -293,16 +293,13 @@ export abstract class WebviewHost<IMapping> implements IDisposable {
             integrationsPostgresPasswordLabel: '',
             integrationsPostgresPasswordPlaceholder: '',
             integrationsPostgresSslLabel: '',
-            integrationsPostgresUnnamedIntegration: '',
             integrationsBigQueryNameLabel: '',
             integrationsBigQueryNamePlaceholder: '',
             integrationsBigQueryProjectIdLabel: '',
             integrationsBigQueryProjectIdPlaceholder: '',
             integrationsBigQueryCredentialsLabel: '',
             integrationsBigQueryCredentialsPlaceholder: '',
             integrationsBigQueryCredentialsRequired: '',
-            integrationsBigQueryInvalidJson: '',
-            integrationsBigQueryUnnamedIntegration: '',
             integrationsRequiredField: '',
             integrationsOptionalField: ''
         };

src/webviews/webview-side/integrations/BigQueryForm.tsx

@@ -1,5 +1,5 @@
 import * as React from 'react';
-import { getLocString } from '../react-common/locReactSide';
+import { format, getLocString } from '../react-common/locReactSide';
 import { BigQueryIntegrationConfig } from './types';
 
 export interface IBigQueryFormProps {
@@ -37,10 +37,7 @@ export const BigQueryForm: React.FC<IBigQueryFormProps> = ({ integrationId, exis
             return true;
         } catch (error) {
             const errorMessage = error instanceof Error ? error.message : 'Invalid JSON format';
-            const invalidJsonMsg = getLocString('integrationsBigQueryInvalidJson', 'Invalid JSON: {0}').replace(
-                '{0}',
-                errorMessage
-            );
+            const invalidJsonMsg = format('Invalid JSON: {0}', errorMessage);
             setCredentialsError(invalidJsonMsg);
             return false;
         }
@@ -60,10 +57,7 @@ export const BigQueryForm: React.FC<IBigQueryFormProps> = ({ integrationId, exis
             return;
         }
 
-        const unnamedIntegration = getLocString(
-            'integrationsBigQueryUnnamedIntegration',
-            'Unnamed BigQuery Integration ({0})'
-        ).replace('{0}', integrationId);
+        const unnamedIntegration = format('Unnamed BigQuery Integration ({0})', integrationId);
 
         const config: BigQueryIntegrationConfig = {
             id: integrationId,

src/webviews/webview-side/integrations/PostgresForm.tsx

@@ -1,5 +1,5 @@
 import * as React from 'react';
-import { getLocString } from '../react-common/locReactSide';
+import { format, getLocString } from '../react-common/locReactSide';
 import { PostgresIntegrationConfig } from './types';
 
 export interface IPostgresFormProps {
@@ -34,10 +34,7 @@ export const PostgresForm: React.FC<IPostgresFormProps> = ({ integrationId, exis
     const handleSubmit = (e: React.FormEvent) => {
         e.preventDefault();
 
-        const unnamedIntegration = getLocString(
-            'integrationsPostgresUnnamedIntegration',
-            'Unnamed PostgreSQL Integration ({0})'
-        ).replace('{0}', integrationId);
+        const unnamedIntegration = format('Unnamed PostgreSQL Integration ({0})', integrationId);
 
         const config: PostgresIntegrationConfig = {
             id: integrationId,