Skip to content

Commit 1504827

Browse files
committed
use pyformat instead of format for snowflake
1 parent 5f4a284 commit 1504827

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/platform/notebooks/deepnote/sqlIntegrationEnvironmentVariablesProvider.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ function convertIntegrationConfigToJson(config: IntegrationConfig): string {
135135
return JSON.stringify({
136136
url: url,
137137
params: params,
138-
param_style: 'format'
138+
param_style: 'pyformat'
139139
});
140140
}
141141

src/platform/notebooks/deepnote/sqlIntegrationEnvironmentVariablesProvider.unit.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@ suite('SqlIntegrationEnvironmentVariablesProvider', () => {
414414
'snowflake://john.doe:secret123@myorg-myaccount/MYDB?warehouse=COMPUTE_WH&role=ANALYST&application=Deepnote'
415415
);
416416
assert.deepStrictEqual(credentialsJson.params, {});
417-
assert.strictEqual(credentialsJson.param_style, 'format');
417+
assert.strictEqual(credentialsJson.param_style, 'pyformat');
418418
});
419419

420420
test('Returns environment variable for Snowflake with legacy null auth (username+password)', async () => {
@@ -492,7 +492,7 @@ suite('SqlIntegrationEnvironmentVariablesProvider', () => {
492492
snowflake_private_key: Buffer.from(privateKey).toString('base64'),
493493
snowflake_private_key_passphrase: 'passphrase123'
494494
});
495-
assert.strictEqual(credentialsJson.param_style, 'format');
495+
assert.strictEqual(credentialsJson.param_style, 'pyformat');
496496
});
497497

498498
test('Returns environment variable for Snowflake with SERVICE_ACCOUNT_KEY_PAIR auth without passphrase', async () => {
@@ -598,7 +598,7 @@ suite('SqlIntegrationEnvironmentVariablesProvider', () => {
598598
const credentialsJson = JSON.parse(envVars['SQL_SNOWFLAKE_MINIMAL']!);
599599
// Should not include warehouse, database, or role in URL when not provided
600600
assert.strictEqual(credentialsJson.url, 'snowflake://user:pass@minimal-account?application=Deepnote');
601-
assert.strictEqual(credentialsJson.param_style, 'format');
601+
assert.strictEqual(credentialsJson.param_style, 'pyformat');
602602
});
603603

604604
test('Skips unsupported Snowflake auth method (OKTA)', async () => {

0 commit comments

Comments
 (0)