Skip to content

Commit 085fafb

Browse files
ArtmannArtmann
committed
fix lint
1 parent cdc465d commit 085fafb

File tree

11 files changed

+96
-94
lines changed

11 files changed

+96
-94
lines changed

‎.github/workflows/ci.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ name: CI
22

33
on:
44
push:
5-
branches: [ main ]
5+
branches: [main]
66
pull_request:
7-
branches: [ main ]
7+
branches: [main]
88
workflow_dispatch:
99

1010
env:
@@ -68,4 +68,4 @@ jobs:
6868

6969
- name: Check dependencies
7070
run: npm run checkDependencies
71-
continue-on-error: true
71+
continue-on-error: true

‎.github/workflows/deps.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,4 +56,4 @@ jobs:
5656
run: npm run postinstall
5757

5858
- name: Check dependencies for issues
59-
run: npm run checkDependencies
59+
run: npm run checkDependencies

‎src/notebooks/deepnote/deepnoteActivationService.ts‎

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,21 @@
1-
import { injectable, inject } from 'inversify'
2-
import { workspace, commands, window, WorkspaceEdit, NotebookEdit, NotebookRange, l10n } from 'vscode'
3-
import { IExtensionSyncActivationService } from '../../platform/activation/types'
4-
import { IExtensionContext } from '../../platform/common/types'
5-
import { DeepnoteNotebookSerializer } from './deepnoteSerializer'
6-
import { DeepnoteProject } from './deepnoteTypes'
7-
import { DeepnoteNotebookSelector } from './deepnoteNotebookSelector'
8-
import { Commands } from '../../platform/common/constants'
1+
import { injectable, inject } from 'inversify';
2+
import { workspace, commands, window, WorkspaceEdit, NotebookEdit, NotebookRange, l10n } from 'vscode';
3+
import { IExtensionSyncActivationService } from '../../platform/activation/types';
4+
import { IExtensionContext } from '../../platform/common/types';
5+
import { DeepnoteNotebookSerializer } from './deepnoteSerializer';
6+
import { DeepnoteProject } from './deepnoteTypes';
7+
import { DeepnoteNotebookSelector } from './deepnoteNotebookSelector';
8+
import { Commands } from '../../platform/common/constants';
99

1010
@injectable()
1111
export class DeepnoteActivationService implements IExtensionSyncActivationService {
12-
constructor(
13-
@inject(IExtensionContext) private extensionContext: IExtensionContext
14-
) {}
12+
constructor(@inject(IExtensionContext) private extensionContext: IExtensionContext) {}
1513

1614
public activate() {
1715
const serializer = new DeepnoteNotebookSerializer();
1816
const selector = new DeepnoteNotebookSelector();
1917

20-
this.extensionContext.subscriptions.push(
21-
workspace.registerNotebookSerializer('deepnote', serializer)
22-
);
18+
this.extensionContext.subscriptions.push(workspace.registerNotebookSerializer('deepnote', serializer));
2319

2420
this.extensionContext.subscriptions.push(
2521
commands.registerCommand(Commands.SelectDeepnoteNotebook, () => this.selectNotebook(selector))
@@ -110,7 +106,12 @@ export class DeepnoteActivationService implements IExtensionSyncActivationServic
110106
}
111107
}
112108
} catch (error) {
113-
await window.showErrorMessage(l10n.t('Error switching notebook: {0}', error instanceof Error ? error.message : l10n.t('Unknown error')));
109+
await window.showErrorMessage(
110+
l10n.t(
111+
'Error switching notebook: {0}',
112+
error instanceof Error ? error.message : l10n.t('Unknown error')
113+
)
114+
);
114115
}
115116
}
116117
}

‎src/notebooks/deepnote/deepnoteDataConverter.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export class DeepnoteDataConverter {
66
convertBlocksToCells(blocks: DeepnoteBlock[]): NotebookCellData[] {
77
return blocks
88
.sort((a, b) => a.sortingKey.localeCompare(b.sortingKey))
9-
.map(block => this.convertBlockToCell(block));
9+
.map((block) => this.convertBlockToCell(block));
1010
}
1111

1212
convertCellsToBlocks(cells: NotebookCellData[]): DeepnoteBlock[] {
@@ -64,7 +64,7 @@ export class DeepnoteDataConverter {
6464
}
6565

6666
private convertDeepnoteOutputsToVSCodeOutputs(deepnoteOutputs: DeepnoteOutput[]): NotebookCellOutput[] {
67-
return deepnoteOutputs.map(output => this.convertSingleOutput(output));
67+
return deepnoteOutputs.map((output) => this.convertSingleOutput(output));
6868
}
6969

7070
private convertSingleOutput(output: DeepnoteOutput): NotebookCellOutput {
@@ -77,7 +77,7 @@ export class DeepnoteDataConverter {
7777
}
7878

7979
private convertVSCodeOutputsToDeepnoteOutputs(vscodeOutputs: NotebookCellOutput[]): DeepnoteOutput[] {
80-
return vscodeOutputs.map(output => {
80+
return vscodeOutputs.map((output) => {
8181
const deepnoteOutput: DeepnoteOutput = {
8282
output_type: 'execute_result'
8383
};
@@ -142,7 +142,7 @@ export class DeepnoteDataConverter {
142142
return [];
143143
}
144144

145-
private createOutputItemForMimeType(mimeType: string, content: any): NotebookCellOutputItem | null {
145+
private createOutputItemForMimeType(mimeType: string, content: unknown): NotebookCellOutputItem | null {
146146
if (mimeType === 'text/plain') {
147147
return NotebookCellOutputItem.text(content as string);
148148
}

‎src/notebooks/deepnote/deepnoteDataConverter.unit.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ suite('DeepnoteDataConverter', () => {
261261
const deepnoteOutputs: DeepnoteOutput[] = [
262262
{
263263
output_type: 'error',
264-
text: 'NameError: name \'x\' is not defined'
264+
text: "NameError: name 'x' is not defined"
265265
}
266266
];
267267

@@ -315,7 +315,7 @@ suite('DeepnoteDataConverter', () => {
315315
assert.strictEqual(outputs[0].metadata?.executionCount, 1);
316316
assert.deepStrictEqual(outputs[0].metadata?.metadata, { custom: 'metadata' });
317317

318-
const mimeTypes = outputs[0].items.map(item => item.mime).sort();
318+
const mimeTypes = outputs[0].items.map((item) => item.mime).sort();
319319
assert.deepStrictEqual(mimeTypes, ['application/json', 'text/html', 'text/plain']);
320320
});
321321

‎src/notebooks/deepnote/deepnoteNotebookManager.unit.test.ts‎

Lines changed: 37 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -27,105 +27,105 @@ suite('DeepnoteNotebookManager', () => {
2727
suite('getCurrentNotebookId', () => {
2828
test('should return undefined for unknown project', () => {
2929
const result = manager.getCurrentNotebookId('unknown-project');
30-
30+
3131
assert.strictEqual(result, undefined);
3232
});
3333

3434
test('should return notebook ID after storing project', () => {
3535
manager.storeOriginalProject('project-123', mockProject, 'notebook-456');
36-
36+
3737
const result = manager.getCurrentNotebookId('project-123');
38-
38+
3939
assert.strictEqual(result, 'notebook-456');
4040
});
4141

4242
test('should return updated notebook ID', () => {
4343
manager.storeOriginalProject('project-123', mockProject, 'notebook-456');
4444
manager.updateCurrentNotebookId('project-123', 'notebook-789');
45-
45+
4646
const result = manager.getCurrentNotebookId('project-123');
47-
47+
4848
assert.strictEqual(result, 'notebook-789');
4949
});
5050
});
5151

5252
suite('getOriginalProject', () => {
5353
test('should return undefined for unknown project', () => {
5454
const result = manager.getOriginalProject('unknown-project');
55-
55+
5656
assert.strictEqual(result, undefined);
5757
});
5858

5959
test('should return original project after storing', () => {
6060
manager.storeOriginalProject('project-123', mockProject, 'notebook-456');
61-
61+
6262
const result = manager.getOriginalProject('project-123');
63-
63+
6464
assert.deepStrictEqual(result, mockProject);
6565
});
6666
});
6767

6868
suite('getSelectedNotebookForUri', () => {
6969
test('should return undefined for unknown URI', () => {
7070
const result = manager.getSelectedNotebookForUri('file:///unknown.deepnote');
71-
71+
7272
assert.strictEqual(result, undefined);
7373
});
7474

7575
test('should return notebook ID after setting', () => {
7676
manager.setSelectedNotebookForUri('file:///test.deepnote', 'notebook-456');
77-
77+
7878
const result = manager.getSelectedNotebookForUri('file:///test.deepnote');
79-
79+
8080
assert.strictEqual(result, 'notebook-456');
8181
});
8282
});
8383

8484
suite('setSelectedNotebookForUri', () => {
8585
test('should store notebook selection and mark for skip prompt', () => {
8686
manager.setSelectedNotebookForUri('file:///test.deepnote', 'notebook-456');
87-
87+
8888
const selectedNotebook = manager.getSelectedNotebookForUri('file:///test.deepnote');
8989
const shouldSkip = manager.shouldSkipPrompt('file:///test.deepnote');
90-
90+
9191
assert.strictEqual(selectedNotebook, 'notebook-456');
9292
assert.strictEqual(shouldSkip, true);
9393
});
9494

9595
test('should overwrite existing selection', () => {
9696
manager.setSelectedNotebookForUri('file:///test.deepnote', 'notebook-456');
9797
manager.setSelectedNotebookForUri('file:///test.deepnote', 'notebook-789');
98-
98+
9999
const result = manager.getSelectedNotebookForUri('file:///test.deepnote');
100-
100+
101101
assert.strictEqual(result, 'notebook-789');
102102
});
103103
});
104104

105105
suite('shouldSkipPrompt', () => {
106106
test('should return false for unknown URI', () => {
107107
const result = manager.shouldSkipPrompt('file:///unknown.deepnote');
108-
108+
109109
assert.strictEqual(result, false);
110110
});
111111

112112
test('should return true and remove skip flag on first call', () => {
113113
manager.setSelectedNotebookForUri('file:///test.deepnote', 'notebook-456');
114-
114+
115115
const firstCall = manager.shouldSkipPrompt('file:///test.deepnote');
116116
const secondCall = manager.shouldSkipPrompt('file:///test.deepnote');
117-
117+
118118
assert.strictEqual(firstCall, true);
119119
assert.strictEqual(secondCall, false);
120120
});
121121

122122
test('should handle multiple URIs independently', () => {
123123
manager.setSelectedNotebookForUri('file:///test1.deepnote', 'notebook-1');
124124
manager.setSelectedNotebookForUri('file:///test2.deepnote', 'notebook-2');
125-
125+
126126
const shouldSkip1 = manager.shouldSkipPrompt('file:///test1.deepnote');
127127
const shouldSkip2 = manager.shouldSkipPrompt('file:///test2.deepnote');
128-
128+
129129
assert.strictEqual(shouldSkip1, true);
130130
assert.strictEqual(shouldSkip2, true);
131131
});
@@ -134,10 +134,10 @@ suite('DeepnoteNotebookManager', () => {
134134
suite('storeOriginalProject', () => {
135135
test('should store both project and current notebook ID', () => {
136136
manager.storeOriginalProject('project-123', mockProject, 'notebook-456');
137-
137+
138138
const storedProject = manager.getOriginalProject('project-123');
139139
const currentNotebookId = manager.getCurrentNotebookId('project-123');
140-
140+
141141
assert.deepStrictEqual(storedProject, mockProject);
142142
assert.strictEqual(currentNotebookId, 'notebook-456');
143143
});
@@ -153,10 +153,10 @@ suite('DeepnoteNotebookManager', () => {
153153

154154
manager.storeOriginalProject('project-123', mockProject, 'notebook-456');
155155
manager.storeOriginalProject('project-123', updatedProject, 'notebook-789');
156-
156+
157157
const storedProject = manager.getOriginalProject('project-123');
158158
const currentNotebookId = manager.getCurrentNotebookId('project-123');
159-
159+
160160
assert.deepStrictEqual(storedProject, updatedProject);
161161
assert.strictEqual(currentNotebookId, 'notebook-789');
162162
});
@@ -166,27 +166,27 @@ suite('DeepnoteNotebookManager', () => {
166166
test('should update notebook ID for existing project', () => {
167167
manager.storeOriginalProject('project-123', mockProject, 'notebook-456');
168168
manager.updateCurrentNotebookId('project-123', 'notebook-789');
169-
169+
170170
const result = manager.getCurrentNotebookId('project-123');
171-
171+
172172
assert.strictEqual(result, 'notebook-789');
173173
});
174174

175175
test('should set notebook ID for new project', () => {
176176
manager.updateCurrentNotebookId('new-project', 'notebook-123');
177-
177+
178178
const result = manager.getCurrentNotebookId('new-project');
179-
179+
180180
assert.strictEqual(result, 'notebook-123');
181181
});
182182

183183
test('should handle multiple projects independently', () => {
184184
manager.updateCurrentNotebookId('project-1', 'notebook-1');
185185
manager.updateCurrentNotebookId('project-2', 'notebook-2');
186-
186+
187187
const result1 = manager.getCurrentNotebookId('project-1');
188188
const result2 = manager.getCurrentNotebookId('project-2');
189-
189+
190190
assert.strictEqual(result1, 'notebook-1');
191191
assert.strictEqual(result2, 'notebook-2');
192192
});
@@ -196,13 +196,13 @@ suite('DeepnoteNotebookManager', () => {
196196
test('should handle complete workflow for multiple files', () => {
197197
const uri1 = 'file:///project1.deepnote';
198198
const uri2 = 'file:///project2.deepnote';
199-
199+
200200
manager.storeOriginalProject('project-1', mockProject, 'notebook-1');
201201
manager.setSelectedNotebookForUri(uri1, 'notebook-1');
202-
202+
203203
manager.storeOriginalProject('project-2', mockProject, 'notebook-2');
204204
manager.setSelectedNotebookForUri(uri2, 'notebook-2');
205-
205+
206206
assert.strictEqual(manager.getCurrentNotebookId('project-1'), 'notebook-1');
207207
assert.strictEqual(manager.getCurrentNotebookId('project-2'), 'notebook-2');
208208
assert.strictEqual(manager.getSelectedNotebookForUri(uri1), 'notebook-1');
@@ -215,16 +215,16 @@ suite('DeepnoteNotebookManager', () => {
215215

216216
test('should handle notebook switching within same project', () => {
217217
const uri = 'file:///project.deepnote';
218-
218+
219219
manager.storeOriginalProject('project-123', mockProject, 'notebook-1');
220220
manager.setSelectedNotebookForUri(uri, 'notebook-1');
221-
221+
222222
manager.updateCurrentNotebookId('project-123', 'notebook-2');
223223
manager.setSelectedNotebookForUri(uri, 'notebook-2');
224-
224+
225225
assert.strictEqual(manager.getCurrentNotebookId('project-123'), 'notebook-2');
226226
assert.strictEqual(manager.getSelectedNotebookForUri(uri), 'notebook-2');
227227
assert.strictEqual(manager.shouldSkipPrompt(uri), true);
228228
});
229229
});
230-
});
230+
});

‎src/notebooks/deepnote/deepnoteNotebookSelector.ts‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,23 +32,23 @@ export class DeepnoteNotebookSelector {
3232

3333
// Pre-select the current notebook if provided
3434
if (currentNotebookId) {
35-
const activeItem = items.find(item => item.notebook.id === currentNotebookId);
35+
const activeItem = items.find((item) => item.notebook.id === currentNotebookId);
3636
if (activeItem) {
3737
quickPick.activeItems = [activeItem];
3838
}
3939
}
4040

4141
let accepted = false;
4242
quickPick.show();
43-
43+
4444
await Promise.race([
4545
toPromise(quickPick.onDidAccept).then(() => (accepted = true)),
4646
toPromise(quickPick.onDidHide)
4747
]);
4848

4949
const selectedItem = accepted ? quickPick.selectedItems[0] : undefined;
5050
quickPick.dispose();
51-
51+
5252
return selectedItem?.notebook;
5353
}
5454

@@ -64,11 +64,7 @@ export class DeepnoteNotebookSelector {
6464

6565
private getDetail(notebook: DeepnoteNotebook): string {
6666
if (notebook.workingDirectory) {
67-
return l10n.t(
68-
'ID: {0} | Working Directory: {1}',
69-
notebook.id,
70-
notebook.workingDirectory
71-
);
67+
return l10n.t('ID: {0} | Working Directory: {1}', notebook.id, notebook.workingDirectory);
7268
}
7369

7470
return l10n.t('ID: {0}', notebook.id);

0 commit comments

Comments
 (0)