Skip to content

Commit b014fff

Browse files
committed
Incorporate PR review suggestions
1 parent b7f5def commit b014fff

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

.circleci/config.yml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,7 @@ jobs:
4646
--tag=978928340082.dkr.ecr.us-east-1.amazonaws.com/${REPOSITORY}:${TAG}${TAG_SUFFIX} \
4747
--tag=docker.io/${REPOSITORY}:${TAG}${TAG_SUFFIX} \
4848
--progress plain \
49-
--platform linux/amd64 \
50-
--platform linux/arm64 \
49+
--platform linux/amd64,linux/arm64 \
5150
--provenance=false \
5251
--sbom=false \
5352
--output type=registry,push=true \
@@ -79,8 +78,7 @@ jobs:
7978
--tag=docker.io/${REPOSITORY}:${TAG}${TAG_SUFFIX} \
8079
--build-arg CIRCLE_PULL_REQUEST=${CIRCLE_PULL_REQUEST} \
8180
--progress plain \
82-
--platform linux/amd64 \
83-
--platform linux/arm64 \
81+
--platform linux/amd64,linux/arm64 \
8482
--provenance=false \
8583
--sbom=false \
8684
--output type=registry,push=true \
@@ -111,8 +109,7 @@ jobs:
111109
--build-arg CIRCLE_PULL_REQUEST=${CIRCLE_PULL_REQUEST} \
112110
--build-arg PYTHON_VERSION=${PYTHON_VERSION} \
113111
--progress plain \
114-
--platform linux/amd64 \
115-
--platform linux/arm64 \
112+
--platform linux/amd64,linux/arm64 \
116113
--provenance=false \
117114
--sbom=false \
118115
--output type=registry,push=true \

python/conda/Dockerfile.conda

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,20 @@ ENV CONDA_ALWAYS_YES=true
1818
# but that would require baking in the URLs for
1919
# different Miniconda installer versions into the Dockerfile.
2020
ARG PYTHON_VERSION
21-
RUN wget --quiet "https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh" -O /tmp/miniconda.sh && \
21+
ARG TARGETARCH
22+
RUN case "$TARGETARCH" in \
23+
amd64) MINICONDA_ARCH="x86_64" ;; \
24+
arm64) MINICONDA_ARCH="aarch64" ;; \
25+
*) echo "Unsupported TARGETARCH: $TARGETARCH" >&2; exit 1 ;; \
26+
esac && \
27+
wget --quiet "https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-${MINICONDA_ARCH}.sh" -O /tmp/miniconda.sh && \
2228
/bin/bash /tmp/miniconda.sh -b -p /opt/conda && \
2329
rm /tmp/miniconda.sh && \
2430
# Use community packages from conda-forge instead of Anaconda Inc. default channels
2531
# which require accepting terms of service & using commercial license for orgs with more than 200 employees
2632
/opt/conda/bin/conda config --add channels conda-forge && \
27-
/opt/conda/bin/conda config --remove channels defaults && \
33+
/opt/conda/bin/conda config --remove channels defaults || true && \
34+
/opt/conda/bin/conda config --set channel_priority strict && \
2835
# Install the correct version of python (as the time of writing, anaconda
2936
# installed python 3.11 by default) for parity with our base image
3037
/opt/conda/bin/conda install python=${PYTHON_VERSION} && \

0 commit comments

Comments
 (0)