Skip to content

Commit dcaa0df

Browse files
committed
fix: Fail fast and use correct directory when combining coverage files
1 parent 7d17871 commit dcaa0df

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -381,6 +381,7 @@ jobs:
381381
path: .coverage
382382
retention-days: 1
383383
include-hidden-files: true
384+
if-no-files-found: error
384385

385386
coverage-combine:
386387
name: Combine and Upload Coverage
@@ -429,20 +430,15 @@ jobs:
429430
mkdir -p coverage-data
430431
i=0
431432
for file in "${coverage_files[@]}"; do
432-
echo "Copying $file to coverage-data/.coverage.$i"
433433
cp "$file" "coverage-data/.coverage.$i"
434434
i=$((i + 1))
435435
done
436436
437-
cd coverage-data
438-
echo "Files in coverage-data:"
439-
ls -la
440-
441-
echo "Running coverage combine..."
442-
coverage combine || { echo "coverage combine failed"; exit 1; }
437+
echo "Running coverage combine from workspace root..."
438+
coverage combine coverage-data/ || { echo "coverage combine failed"; exit 1; }
443439
444440
echo "Generating XML report..."
445-
coverage xml -o coverage.xml || { echo "coverage xml failed"; exit 1; }
441+
coverage xml -o coverage-data/coverage.xml || { echo "coverage xml failed"; exit 1; }
446442
447443
echo "Generating text report..."
448444
coverage report || { echo "coverage report failed"; exit 1; }

0 commit comments

Comments
 (0)