Skip to content

Added compatibility for NumPy >= 1.2.0 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added compatibility for NumPy >= 1.2.0 #16

wants to merge 2 commits into from

Conversation

dtung8068
Copy link

No description provided.

waterdeepmage
waterdeepmage reviewed Mar 5, 2025
View reviewed changes
Copy link

@waterdeepmage waterdeepmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can directly return np.int64 for numpy version >= 1.2.0
However, it would be great if the repo owner could give requirement.txt to indicate what versions of libraries are needed for this project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waterdeepmage waterdeepmage waterdeepmage left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtung8068 @waterdeepmage