Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Allows build project with JDK 21 #2903

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

frankfliu
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2023

Codecov Report

Attention: 1363 lines in your changes are missing coverage. Please review.

Comparison is base (bb5073f) 72.08% compared to head (da15dd1) 72.28%.
Report is 939 commits behind head on master.

Files Patch % Lines
...va/ai/djl/modality/nlp/generate/TextGenerator.java 2.81% 276 Missing ⚠️
.../java/ai/djl/modality/nlp/generate/SeqBatcher.java 0.75% 132 Missing ⚠️
...ity/nlp/generate/ContrastiveSeqBatchScheduler.java 2.97% 98 Missing ⚠️
...i/djl/modality/nlp/generate/SeqBatchScheduler.java 9.83% 55 Missing ⚠️
.../java/ai/djl/modality/cv/BufferedImageFactory.java 40.96% 47 Missing and 2 partials ⚠️
...a/ai/djl/modality/nlp/generate/StepGeneration.java 2.04% 48 Missing ⚠️
api/src/main/java/ai/djl/ndarray/NDArray.java 43.42% 39 Missing and 4 partials ⚠️
...n/java/ai/djl/modality/cv/output/CategoryMask.java 22.00% 39 Missing ⚠️
...i/src/main/java/ai/djl/ndarray/NDArrayAdapter.java 71.21% 31 Missing and 7 partials ⚠️
.../cv/translator/SemanticSegmentationTranslator.java 37.50% 35 Missing ⚠️
... and 76 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2903      +/-   ##
============================================
+ Coverage     72.08%   72.28%   +0.19%     
- Complexity     5126     7186    +2060     
============================================
  Files           473      708     +235     
  Lines         21970    32013   +10043     
  Branches       2351     3337     +986     
============================================
+ Hits          15838    23141    +7303     
- Misses         4925     7281    +2356     
- Partials       1207     1591     +384     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frankfliu frankfliu merged commit fcfc928 into deepjavalibrary:master Jan 5, 2024
5 checks passed
@frankfliu frankfliu deleted the jdk21 branch January 5, 2024 00:06
zachgk added a commit to zachgk/djl that referenced this pull request Jan 11, 2024
In JDK21, it now throws the serial warning for including potentially
unserializable instance variables. This includes the standard Java data
structures like List, Set, and Map. This changes the JDK21 support from
deepjavalibrary#2903 to suppress the warning rather
than no longer serializing the variables.
zachgk added a commit that referenced this pull request Jan 16, 2024
* Suppress serial warning for JDK21

In JDK21, it now throws the serial warning for including potentially
unserializable instance variables. This includes the standard Java data
structures like List, Set, and Map. This changes the JDK21 support from
#2903 to suppress the warning rather
than no longer serializing the variables.

* Keep CategoryMask as transient
frankfliu added a commit that referenced this pull request Apr 26, 2024
frankfliu pushed a commit that referenced this pull request Apr 26, 2024
* Suppress serial warning for JDK21

In JDK21, it now throws the serial warning for including potentially
unserializable instance variables. This includes the standard Java data
structures like List, Set, and Map. This changes the JDK21 support from
#2903 to suppress the warning rather
than no longer serializing the variables.

* Keep CategoryMask as transient
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants