[python] Update chat properties #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xyang16
force-pushed
the
chat
branch
2 times, most recently
from
ea43095 to
4617a32
Compare
lanking520
approved these changes
Mar 30, 2024
xyang16
changed the title
xyang16
force-pushed
the
chat
branch
7 times, most recently
from
b54cf25 to
ad0fb3a
Compare
frankfliu
reviewed
Mar 31, 2024
| @@ -12,7 +12,7 @@ | |||
| # the specific language governing permissions and limitations under the License. | |||
| from typing import Optional, Union, List, Dict | |||
|
|
|||
| from pydantic.v1 import BaseModel, Field, validator, root_validator | |||
| from pydantic import BaseModel, Field, validator, root_validator | |||
There was a problem hiding this comment.
Are we ready to upgrade pydantic?
There was a problem hiding this comment.
@frankfliu Sorry I just saw your comment, we are already installing pydantic 2.6 in the docker, I didn't upgrade it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about