Supports docker build with local .deb #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we only supported docker builds that depend on the DJL global djl-serving.deb for the release. This PR begins by updating the Dockerfiles to search for `serving/docker/distributions/*.deb` and copy it to the container if it exists. This can then be used for the build instead of downloading. It enables easier local testing with a custom version of DJL Serving. As part of this, it also creates a new gradle task `dockerDeb` that will move the build into the docker building context directory. It will be git ignored and cleaned through gradle. Finally, it also modifies the nightly CI to no longer rely on the global build. This means that the nightly publish job does not require running the serving publish in the DJL repo first.
sindhuvahinis
approved these changes
Oct 30, 2023
zachgk
added a commit
to zachgk/djl-serving
that referenced
this pull request
Nov 16, 2023
zachgk
added a commit
to zachgk/djl-serving
that referenced
this pull request
Nov 16, 2023
zachgk
added a commit
to zachgk/djl-serving
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we only supported docker builds that depend on the DJL global djl-serving.deb for the release. This PR begins by updating the Dockerfiles to search for
serving/docker/distributions/*.deband copy it to the container if it exists. This can then be used for the build instead of downloading. It enables easier local testing with a custom version of DJL Serving.As part of this, it also creates a new gradle task
dockerDebthat will move the build into the docker building context directory. It will be git ignored and cleaned through gradle.Finally, it also modifies the nightly CI to no longer rely on the global build. This means that the nightly publish job does not require running the serving publish in the DJL repo first.