Fixed unstable unit test verified by valgrind.

Juha Heiskanen · juhhei01 · commit 2680dd668938 · 2018-03-08T09:31:02.000+02:00
Change-Id: I1e4c9832e029e565c7a717ad82e516456adb57b5
diff --git a/test/nanostack/unittest/6LoWPAN/adaptation_interface/test_adaptation_interface.c b/test/nanostack/unittest/6LoWPAN/adaptation_interface/test_adaptation_interface.c
@@ -937,6 +937,7 @@ bool test_lowpan_adaptation_interface_data_ind()
     entry.mac_parameters = &params;
     entry.mac_security_key_usage_update_cb = mac_security_key_update_cb;
     mcps_data_ind_t data_ind;
+    memset(&data_ind, 0, sizeof(mcps_data_ind_t));
     buffer_dyn_stub.buffer_ptr = NULL;
     lowpan_adaptation_interface_data_ind( NULL, &data_ind );
 
diff --git a/test/nanostack/unittest/6LoWPAN/ws_llc_data_service/test_ws_llc_data_service.c b/test/nanostack/unittest/6LoWPAN/ws_llc_data_service/test_ws_llc_data_service.c
@@ -174,6 +174,7 @@ bool test_ws_llc_reset()
     mpx_api->mpx_data_request(mpx_api, &data_req,  0xA0ED);
     nsdynmemlib_stub.returnCounter = 1;
     asynch_request_t asynch_request;
+    memset(&asynch_request, 0, sizeof(asynch_request_t));
     asynch_request.message_type = WS_FT_PAN_ADVERT;
 
     ws_llc_asynch_request(&interface, &asynch_request);
@@ -192,6 +193,7 @@ bool test_asynch_msg_send()
     mpx_api_t *mpx_api = ws_llc_mpx_api_get(&interface);
     register_mpx_user(mpx_api);
     asynch_request_t asynch_request;
+    memset(&asynch_request, 0, sizeof(asynch_request_t));
     asynch_request.message_type = WS_FT_PAN_ADVERT_SOL;
     message_id = WS_FT_PAN_ADVERT_SOL;
     valid_conf = false;
@@ -375,6 +377,7 @@ bool test_mpx_msg_rx()
     register_mpx_user(mpx_api);
 
     mcps_data_ind_t data_ind;
+    memset(&data_ind, 0, sizeof(mcps_data_ind_t));
     uint8_t utt_type = 0;
     uint8_t payload_buf[100];
     uint8_t header_buf[100];
diff --git a/test/nanostack/unittest/6lp_mac/beacon_handler/test_beacon_handler.c b/test/nanostack/unittest/6lp_mac/beacon_handler/test_beacon_handler.c
@@ -59,6 +59,7 @@ bool test_beacon_received()
 
     protocol_core_stub.entry_ptr = NULL;
     mlme_beacon_ind_t ind;
+    memset(&ind, 0, sizeof(mlme_beacon_ind_t));
     beacon_received(0, &ind);
 
     protocol_interface_info_entry_t entry;
@@ -112,6 +113,7 @@ bool test_beacon_received()
     params.beacon_compare_rx_cb_ptr = &compare_cb;
     ind.beacon_data_length = PLAIN_BEACON_PAYLOAD_SIZE+6;
     uint8_t dat[PLAIN_BEACON_PAYLOAD_SIZE+6];
+    memset(dat, 0, PLAIN_BEACON_PAYLOAD_SIZE+6);
     dat[PLAIN_BEACON_PAYLOAD_SIZE] = 0x00;
 
     ind.beacon_data = &dat;
@@ -151,6 +153,7 @@ bool test_beacon_received()
     nwk_pan_descriptor_t info;
     memset(&info, 0, sizeof(nwk_pan_descriptor_t));
     mlme_pan_descriptor_t pan;
+    memset(&pan, 0, sizeof(mlme_pan_descriptor_t));
     info.pan_descriptor = &pan;
     pan.LogicalChannel = 1;
     ind.PANDescriptor.LogicalChannel = 2;
@@ -169,7 +172,9 @@ bool test_beacon_received()
     ns_dyn_mem_free(info.next);
 
     mlme_pan_descriptor_t pan2;
+    memset(&pan2, 0, sizeof(mlme_pan_descriptor_t));
     nwk_pan_descriptor_t info2;
+    memset(&info2, 0, sizeof(nwk_pan_descriptor_t));
     info2.pan_descriptor = &pan2;
     pan2.LogicalChannel = 2;
     pan2.CoordPANId = 2;
@@ -179,7 +184,9 @@ bool test_beacon_received()
     info.next = &info2;
 
     mlme_pan_descriptor_t pan3;
+    memset(&pan3, 0, sizeof(mlme_pan_descriptor_t));
     nwk_pan_descriptor_t info3;
+    memset(&info3, 0, sizeof(nwk_pan_descriptor_t));
     info3.pan_descriptor = &pan3;
     pan3.LogicalChannel = 3;
     info2.next = &info3;
diff --git a/test/nanostack/unittest/6lp_mac/mac_ie_lib/test_mac_ie_lib.c b/test/nanostack/unittest/6lp_mac/mac_ie_lib/test_mac_ie_lib.c
@@ -230,7 +230,9 @@ bool test_mac_ie_header_discover()
 bool test_mac_ie_header_sub_id_discover()
 {
     uint8_t buffer[60];
+    memset(buffer, 0, 60);
     mac_header_IE_t header_ie;
+    memset(&header_ie, 0, sizeof(mac_header_IE_t));
     header_ie.id = MAC_HEADER_ASSIGNED_EXTERNAL_ORG_IE_ID;
     if (mac_ie_header_discover(buffer, 0, &header_ie) ) {
         return false;
diff --git a/test/nanostack/unittest/6lp_mac/mac_response_handler/test_mac_response_handler.c b/test/nanostack/unittest/6lp_mac/mac_response_handler/test_mac_response_handler.c
@@ -67,11 +67,14 @@ void mlme_test_req(const mac_api_t* api, mlme_primitive id, const void *data)
 bool test_mlme_confirm_handler()
 {
     mac_api_t api;
+    memset(&api, 0, sizeof(mac_api_t));
     api.mlme_req = mlme_test_req;
     protocol_core_stub.entry_ptr = NULL;
     mlme_confirm_handler(&api, 0, NULL);
     protocol_interface_info_entry_t entry;
+    memset(&entry, 0, sizeof(protocol_interface_info_entry_t));
     arm_15_4_mac_parameters_t params;
+    memset(&params, 0, sizeof(arm_15_4_mac_parameters_t));
     entry.mac_parameters = &params;
     entry.mac_api = &api;
     protocol_core_stub.entry_ptr = &entry;
diff --git a/test/nanostack/unittest/mac/mac_filter/test_mac_filter.c b/test/nanostack/unittest/mac/mac_filter/test_mac_filter.c
@@ -54,6 +54,7 @@ bool test_mac_filter_modify_link_quality()
     //Stop is tested last to keep filter enabled during the test
 
     mac_pre_parsed_frame_t frame;
+    memset(&frame, 0, sizeof(mac_pre_parsed_frame_t));
     frame.fcf_dsn.SrcAddrMode = MAC_ADDR_MODE_NONE;
     ret = mac_filter_modify_link_quality(0, &frame);
     if( 0 != ret ){
diff --git a/test/nanostack/unittest/mac/mac_header_helper_functions/test_mac_header_helper_functions.c b/test/nanostack/unittest/mac/mac_header_helper_functions/test_mac_header_helper_functions.c
@@ -332,6 +332,7 @@ bool test_mac_header_get_dst_panid()
 bool test_mac_header_get_src_address()
 {
     mac_fcf_sequence_t seq;
+    memset(&seq, 0, sizeof(mac_fcf_sequence_t));
     uint8_t ptr[25];
     memset(&ptr, 0, 25);
     uint8_t addr[15];
@@ -365,6 +366,7 @@ bool test_mac_header_get_src_address()
 bool test_mac_header_get_dst_address()
 {
     mac_fcf_sequence_t seq;
+    memset(&seq, 0, sizeof(mac_fcf_sequence_t));
     uint8_t ptr[25];
     memset(&ptr, 0, 25);
     uint8_t addr[15];
diff --git a/test/nanostack/unittest/mac/mac_indirect_data/test_mac_indirect_data.c b/test/nanostack/unittest/mac/mac_indirect_data/test_mac_indirect_data.c
@@ -78,7 +78,9 @@ bool test_mac_indirect_data_ttl_handle()
     mac_indirect_data_ttl_handle(NULL, 0); //Crashes if NULL not handled
 
     arm_device_driver_list_s list;
+    memset(&list, 0, sizeof(arm_device_driver_list_s));
     protocol_interface_rf_mac_setup_s cur;
+    memset(&cur, 0, sizeof(protocol_interface_rf_mac_setup_s));
     cur.dev_driver = &list;
     cur.dev_driver->phy_driver = &device_driver;
     cur.indirect_pd_data_request_queue = NULL;
@@ -91,6 +93,9 @@ bool test_mac_indirect_data_ttl_handle()
     mac_pre_build_frame_t frame;
     mac_pre_build_frame_t frame2;
     mac_pre_build_frame_t frame3;
+    memset(&frame, 0, sizeof(mac_pre_build_frame_t));
+    memset(&frame2, 0, sizeof(mac_pre_build_frame_t));
+    memset(&frame3, 0, sizeof(mac_pre_build_frame_t));
     frame.next = &frame2;
     frame2.next = &frame3;
     frame3.next = NULL;
@@ -99,6 +104,7 @@ bool test_mac_indirect_data_ttl_handle()
     mac_indirect_data_ttl_handle(&cur, 0);
 
     mac_api_t api;
+    memset(&api, 0, sizeof(mac_api_t));
     sw_mac_stub.mac_api_ptr = &api;
     frame.buffer_ttl = 2;
     api.data_conf_cb = &test_data_confirm_cb;
diff --git a/test/nanostack/unittest/mac/mac_mcps_sap/test_mac_mcps_sap.c b/test/nanostack/unittest/mac/mac_mcps_sap/test_mac_mcps_sap.c
@@ -858,11 +858,18 @@ bool test_mac_mcps_data_indication()
 
 
     ccm_globals_t ccm_ptr;
+    memset(&ccm_ptr, 0, sizeof(ccm_globals_t));
     mac_api_t mac_api;
+    memset(&mac_api, 0, sizeof(mac_api_t));
     mlme_key_descriptor_t key_description;
+    memset(&key_description, 0, sizeof(mlme_key_descriptor_t));
     mlme_device_descriptor_t device_description;
+    memset(&device_description, 0, sizeof(mlme_device_descriptor_t));
     mac_aux_security_header_t secuirity_params;
+    memset(&secuirity_params, 0, sizeof(mac_aux_security_header_t));
     mlme_key_device_descriptor_t key_device_description;
+    memset(&key_device_description, 0, sizeof(mlme_key_device_descriptor_t));
+
     mcps_data_req_t data_req;
     memset(&data_req, 0, sizeof(mcps_data_req_t));
 
@@ -2213,17 +2220,23 @@ bool test_mcps_sap_pd_confirm()
 bool test_mcps_sap_data_req_handler()
 {
     ccm_globals_t ccm_ptr;
+    memset(&ccm_ptr, 0, sizeof(ccm_globals_t));
     mac_api_t mac_api;
+    memset(&mac_api, 0, sizeof(mac_api_t));
     mlme_key_descriptor_t key_description;
+    memset(&key_description, 0, sizeof(mlme_key_descriptor_t));
     mlme_device_descriptor_t device_description;
+    memset(&device_description, 0, sizeof(mlme_device_descriptor_t));
     mac_aux_security_header_t secuirity_params;
+    memset(&secuirity_params, 0, sizeof(mac_aux_security_header_t));
     mcps_data_req_t data_req;
     memset(&data_req, 0, sizeof(mcps_data_req_t));
 
     uint8_t tx_buf[127];
     uint8_t msdu_handle = 0;
 
     uint8_t tx_temp[200];
+    memset(tx_temp, 0, 200);
     protocol_interface_rf_mac_setup_s *rf_mac_setup = test_mac_rf_mac_class_allocate();
     memset(tx_buf, 1, 127);
 
@@ -2468,10 +2481,15 @@ bool test_mac_mcps_trig_buffer_from_queue()
 {
 
     ccm_globals_t ccm_ptr;
+    memset(&ccm_ptr, 0, sizeof(ccm_globals_t));
     mac_api_t mac_api;
+    memset(&mac_api, 0, sizeof(mac_api_t));
     mlme_key_descriptor_t key_description;
+    memset(&key_description, 0, sizeof(mlme_key_descriptor_t));
     mlme_device_descriptor_t device_description;
+    memset(&device_description, 0, sizeof(mlme_device_descriptor_t));
     mac_aux_security_header_t secuirity_params;
+    memset(&secuirity_params, 0, sizeof(mac_aux_security_header_t));
     uint8_t tx_buf[127];
     protocol_interface_rf_mac_setup_s *rf_mac_setup = test_mac_rf_mac_class_allocate();
     memset(tx_buf, 1, 127);
diff --git a/test/nanostack/unittest/mac/mac_mlme/test_mac_mlme.c b/test/nanostack/unittest/mac/mac_mlme/test_mac_mlme.c
@@ -230,14 +230,19 @@ bool test_mac_mlme_scan_request()
     memset(conf, 0, sizeof(mlme_scan_conf_t));
     setup.mac_mlme_scan_resp = conf;
     mac_pre_build_frame_t fr;
+    memset(&fr, 0, sizeof(mac_pre_build_frame_t));
     setup.active_pd_data_request = &fr;
     mlme_scan_t scan;
+    memset(&scan, 0, sizeof(mlme_scan_t));
     arm_device_driver_list_s list;
+    memset(&list, 0, sizeof(arm_device_driver_list_s));
     phy_device_driver_s drv;
+    memset(&drv, 0, sizeof(phy_device_driver_s));
     list.phy_driver = &drv;
     setup.dev_driver = &list;
     setup.dev_driver->phy_driver->link_type = PHY_LINK_15_4_2_4GHZ_TYPE;
     mac_api_t api;
+    memset(&api, 0, sizeof(mac_api_t));
     sw_mac_stub.mac_api_ptr = &api;
     api.mlme_conf_cb = &mlme_conf;
     scan.ScanChannels.channel_page = 0;
@@ -1249,13 +1254,17 @@ bool test_mac_mlme_event_cb()
 bool test_mac_mlme_timer_cb()
 {
     protocol_interface_rf_mac_setup_s *setup;
+
     uint8_t buf[8];
     memset(&buf, 0, 8);
     arm_device_driver_list_s list;
+    memset(&list, 0, sizeof(arm_device_driver_list_s));
     phy_device_driver_s drv;
-
+    memset(&drv, 0, sizeof(phy_device_driver_s));
     phy_device_channel_page_s phy_channel_pages;
+    memset(&phy_channel_pages, 0, sizeof(phy_device_channel_page_s));
         phy_rf_channel_configuration_s rf_channel_configuration;
+        memset(&rf_channel_configuration, 0, sizeof(phy_rf_channel_configuration_s));
         rf_channel_configuration.datarate = 250000;
         rf_channel_configuration.number_of_channels = 16;
         rf_channel_configuration.modulation = M_OQPSK;
@@ -1276,6 +1285,7 @@ bool test_mac_mlme_timer_cb()
     nsdynmemlib_stub.returnCounter = 3;
     drv.address_write = &addr_write;
     mac_description_storage_size_t storage_sizes;
+    memset(&storage_sizes, 0, sizeof(mac_description_storage_size_t));
     storage_sizes.device_decription_table_size = 32;
     storage_sizes.key_description_table_size = 6;
     storage_sizes.key_lookup_size = 1;
@@ -1318,6 +1328,7 @@ bool test_mac_mlme_set_active_state()
 bool test_mac_mlme_data_base_allocate()
 {
     mac_description_storage_size_t storage_sizes;
+    memset(&storage_sizes, 0, sizeof(mac_description_storage_size_t));
     storage_sizes.device_decription_table_size = 32;
     storage_sizes.key_description_table_size = 6;
     storage_sizes.key_lookup_size = 1;
@@ -1330,6 +1341,7 @@ bool test_mac_mlme_data_base_allocate()
     uint8_t buf[8];
     memset(buf, 3, 8);
     arm_device_driver_list_s list;
+    memset(&list, 0, sizeof(arm_device_driver_list_s));
     list.phy_driver = NULL;
 
     setup = mac_mlme_data_base_allocate(NULL, &list, &storage_sizes);
@@ -1350,8 +1362,11 @@ bool test_mac_mlme_data_base_allocate()
         return false;
     }
     phy_device_driver_s drv;
+    memset(&drv, 0, sizeof(phy_device_driver_s));
     phy_device_channel_page_s phy_channel_pages;
+    memset(&phy_channel_pages, 0, sizeof(phy_device_channel_page_s));
     phy_rf_channel_configuration_s rf_channel_configuration;
+    memset(&rf_channel_configuration, 0, sizeof(phy_rf_channel_configuration_s));
     rf_channel_configuration.datarate = 250000;
     rf_channel_configuration.number_of_channels = 16;
     rf_channel_configuration.modulation = M_OQPSK;
diff --git a/test/nanostack/unittest/mac/mac_pd_sap/test_mac_pd_sap.c b/test/nanostack/unittest/mac/mac_pd_sap/test_mac_pd_sap.c
@@ -603,6 +603,7 @@ bool test_mac_pd_sap_state_machine()
     phy_device_driver_s dev_driver;
 
     uint8_t tx_buffer[127];
+    memset(tx_buffer, 0, 127);
 
     memset(&rf_ptr, 0, sizeof(protocol_interface_rf_mac_setup_s));
     memset(&driver, 0, sizeof(arm_device_driver_list_s));
@@ -696,6 +697,7 @@ bool test_mac_pd_sap_state_machine()
 
     // FHSS TESTS START
     mac_pre_build_frame_t temp_buf;
+    memset(&temp_buf, 0, sizeof(mac_pre_build_frame_t));
     rf_ptr.fhss_api = ns_fhss_create(0, 0);
     fhss_config_stub.fhss_api_ptr.tx_handle = &fhss_tx_handle_callback;
     fhss_config_stub.fhss_api_ptr.check_tx_conditions = &fhss_check_tx_conditions_callback;
diff --git a/test/nanostack/unittest/mac/mac_security_mib/test_mac_security_mib.c b/test/nanostack/unittest/mac/mac_security_mib/test_mac_security_mib.c
@@ -257,17 +257,20 @@ bool test_mac_sec_mib_device_description_get()
     memset(&setup, 0, sizeof(protocol_interface_rf_mac_setup_s));
 
     uint8_t mac16[2];
+    memset(mac16, 0, 2);
     if( mac_sec_mib_device_description_get(&setup, &mac16, MAC_ADDR_MODE_16_BIT) ){
         return false;
     }
 
     uint8_t mac64[8];
+    memset(mac64, 0, 8);
     if( mac_sec_mib_device_description_get(&setup, &mac64, MAC_ADDR_MODE_64_BIT) ){
         return false;
     }
 
     nsdynmemlib_stub.returnCounter = 5;
     mac_description_storage_size_t storage_sizes;
+    memset(&storage_sizes, 0, sizeof(mac_description_storage_size_t));
     storage_sizes.device_decription_table_size = 32;
     storage_sizes.key_description_table_size = 6;
     storage_sizes.key_lookup_size = 1;
diff --git a/test/nanostack/unittest/mac/rf_driver_storage/test_rf_driver_storage.c b/test/nanostack/unittest/mac/rf_driver_storage/test_rf_driver_storage.c
@@ -185,11 +185,14 @@ bool test_arm_net_phy_driver_pointer()
 
 bool test_arm_net_phy_mac64_set()
 {
+    arm_net_phy_unregister(0);
     if( -1 != arm_net_phy_mac64_set(NULL, 0) ){
         return false;
     }
     phy_device_driver_s driver;
+    memset(&driver, 0, sizeof(phy_device_driver_s));
     uint8_t mac[8];
+    memset(mac, 0, 8);
     driver.PHY_MAC = &mac;
     protocol_tun_driver_stub.int8_value = 0;
     nsdynmemlib_stub.returnCounter = 1;
@@ -212,10 +215,15 @@ bool test_arm_net_phy_mac64_set()
 
 bool test_arm_net_phy_mac64_get()
 {
+    arm_net_phy_unregister(0);
     if( arm_net_phy_mac64_get(0) ){
         return false;
     }
     phy_device_driver_s driver;
+    memset(&driver, 0, sizeof(phy_device_driver_s));
+    uint8_t mac[8];
+    memset(mac, 0, 8);
+    driver.PHY_MAC = &mac;
     protocol_tun_driver_stub.int8_value = 0;
     nsdynmemlib_stub.returnCounter = 1;
 
@@ -241,8 +249,10 @@ bool test_arm_net_phy_rf_type()
         return false;
     }
     phy_device_driver_s driver;
+    memset(&driver, 0, sizeof(phy_device_driver_s));
     driver.link_type = PHY_LINK_15_4_2_4GHZ_TYPE;
     phy_device_channel_page_s phy_channel_pages;
+    memset(&phy_channel_pages, 0, sizeof(phy_device_channel_page_s));
     phy_rf_channel_configuration_s rf_channel_configuration;
     memset(&rf_channel_configuration, 0, sizeof(phy_rf_channel_configuration_s));
     phy_channel_pages.rf_channel_configuration = &rf_channel_configuration;
@@ -270,10 +280,13 @@ bool test_arm_net_phy_rf_type()
 #define MLE_RAND_HIGH  0x8CCD // 1 + 0.1; maximum for "1+RAND"
 bool test_arm_net_phy_mtu_size()
 {
+    arm_net_phy_unregister(0);
+
     if( 0 != arm_net_phy_mtu_size(0) ){
         return false;
     }
     phy_device_driver_s driver;
+    memset(&driver, 0, sizeof(phy_device_driver_s));
     driver.phy_MTU = 7;
     protocol_tun_driver_stub.int8_value = 0;
     nsdynmemlib_stub.returnCounter = 1;
@@ -301,7 +314,10 @@ static void teset_mib_observer(const mlme_set_t * set_req)
 
 bool test_arm_net_observer_cb_set()
 {
+    arm_net_phy_unregister(0);
+
     phy_device_driver_s driver;
+    memset(&driver, 0, sizeof(phy_device_driver_s));
     protocol_tun_driver_stub.int8_value = 0;
     nsdynmemlib_stub.returnCounter = 1;
 
diff --git a/test/nanostack/unittest/mac/serial_mac_api/test_serial_mac_api.c b/test/nanostack/unittest/mac/serial_mac_api/test_serial_mac_api.c
diff --git a/test/nanostack/unittest/mac/sw_mac/test_sw_mac.c b/test/nanostack/unittest/mac/sw_mac/test_sw_mac.c
diff --git a/test/nanostack/unittest/mac/virtual_rf_client/test_virtual_rf_client.c b/test/nanostack/unittest/mac/virtual_rf_client/test_virtual_rf_client.c
