Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid Pop token format #1664

Open
4 tasks
K1li4nL opened this issue Jun 9, 2023 · 3 comments
Open
4 tasks

Valid Pop token format #1664

K1li4nL opened this issue Jun 9, 2023 · 3 comments
Labels
be1-go be2-scala fe1-web fe2-android good first issue Good for newcomers P2 First Level Priority (Should fix)

Comments

@K1li4nL
Copy link
Contributor

K1li4nL commented Jun 9, 2023

For now the form a valid PoP token must have is undefined. For example, the scala backend will consider any base64 strings to be acceptable pop tokens, including empty ones, leading to issues when creating channels for rollcall participants... Another example is Fe1 that doesn't even have the requirement of them being base64 when scanning tokens during rollcall. There is a need to agree on the format (i.e: regex) valid pop token should have so as to avoid as much as possible undefined behaviours among subsystems.

Subsystems concerned:

Front-ends:
  • Fe1-Web (please include browser's names & version)
  • Fe2-Android (please specify if phone or emulation, and Android version)
Back-ends:
  • Be1-Go
  • Be2-Scala
@K1li4nL K1li4nL added be2-scala fe1-web be1-go fe2-android P2 First Level Priority (Should fix) labels Jun 9, 2023
@Tyratox Tyratox added the good first issue Good for newcomers label Feb 22, 2024
@Tyratox
Copy link
Contributor

Tyratox commented Feb 22, 2024

@osm-alt
Copy link
Contributor

osm-alt commented Mar 4, 2024

I see that all tasks have been marked as done. Should this issue be closed?

@K1li4nL
Copy link
Contributor Author

K1li4nL commented Mar 10, 2024

My bad, the way I put it is confusing (I initially selected all the systems as a way to show they were all concerned, edited now). Given that the pop token is still defined as a format-less string I wouldn't say this issues is solved (unless it is decided things are good enough this way)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
be1-go be2-scala fe1-web fe2-android good first issue Good for newcomers P2 First Level Priority (Should fix)
Projects
None yet
Development

No branches or pull requests

3 participants