Valibot update and json schema migration #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses issues decs#68 and decs#75. Changes include: - Updated `valibot` to `^1.1.0` in `packages/valibot`, `packages/all`, and `packages/main`. - Replaced the deprecated `@gcornut/valibot-json-schema` with the official `@valibot/to-json-schema` (`^1.3.0`) in the same packages. - Updated `packages/valibot/src/serialization.ts` to use the new `@valibot/to-json-schema` library and its updated API (e.g., `toJsonSchema` function and options). - Reviewed Valibot v1.1.0 documentation; no breaking changes were found for the existing validation logic in `packages/valibot/src/validation.ts` and `packages/valibot/src/resolver.ts`. Work Progress & Blockers: - I've completed the core code changes for updating Valibot and its JSON schema generation. - However, testing and full verification are currently BLOCKED due to a persistent monorepo-wide issue with TypeScript declaration file (DTS) generation using `tsup`. The build fails with errors like `TS2307: Cannot find module 'valibot' or its corresponding type declarations.` - I made several attempts to resolve this build issue by modifying `tsconfig.json` files and `tsup.config.ts` (e.g., adjusting `typeRoots`, `types`, `include` paths, `tsup`'s `dts.resolve` and `external` options), but these were unsuccessful and have been reverted as per your request. - This underlying build issue needs to be addressed at the monorepo level to allow tests to pass and ensure the stability of these changes.
🦋 Changeset detectedLatest commit: 869a155 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses issues #68 and #75.
Changes include:
valibotto^1.1.0inpackages/valibot,packages/all, andpackages/main.@gcornut/valibot-json-schemawith the official@valibot/to-json-schema(^1.3.0) in the same packages.packages/valibot/src/serialization.tsto use the new@valibot/to-json-schemalibrary and its updated API (e.g.,toJsonSchemafunction and options).