Skip to content

Commit c1ea975

Browse files
committed
Rename AsfFile.AudioProperties to Properties
Aligns AsfFile with the naming convention used by other format types (FlacFile, Mp4File, OggVorbisFile, WavFile, etc.) which all use 'Properties' for audio properties.
1 parent 698b5cf commit c1ea975

File tree

4 files changed

+17
-17
lines changed

4 files changed

+17
-17
lines changed

src/TagLibSharp2/Asf/AsfFile.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public sealed class AsfFile : IMediaFile
2323
/// <summary>
2424
/// Gets the audio properties.
2525
/// </summary>
26-
public AudioProperties AudioProperties { get; }
26+
public AudioProperties Properties { get; }
2727

2828
/// <summary>
2929
/// Gets the source file path if the file was read from disk.
@@ -36,15 +36,15 @@ public sealed class AsfFile : IMediaFile
3636
Tag? IMediaFile.Tag => Tag;
3737

3838
/// <inheritdoc />
39-
IMediaProperties? IMediaFile.AudioProperties => AudioProperties;
39+
IMediaProperties? IMediaFile.AudioProperties => Properties;
4040

4141
/// <inheritdoc />
4242
public MediaFormat Format => MediaFormat.Asf;
4343

4444
AsfFile (AsfTag tag, AudioProperties audioProperties)
4545
{
4646
Tag = tag;
47-
AudioProperties = audioProperties;
47+
Properties = audioProperties;
4848
}
4949

5050
// ═══════════════════════════════════════════════════════════════

tests/TagLibSharp2.Tests/Asf/AsfFileRoundTripTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,8 @@ public void AudioProperties_PreservedAfterMetadataChange ()
141141
var file = result.File!;
142142

143143
// Store original audio properties
144-
var originalSampleRate = file.AudioProperties.SampleRate;
145-
var originalChannels = file.AudioProperties.Channels;
144+
var originalSampleRate = file.Properties.SampleRate;
145+
var originalChannels = file.Properties.Channels;
146146

147147
// Modify metadata
148148
file.Tag.Title = "Modified Title";
@@ -154,8 +154,8 @@ public void AudioProperties_PreservedAfterMetadataChange ()
154154
var file2 = result2.File!;
155155

156156
// Assert: Audio properties unchanged
157-
Assert.AreEqual (originalSampleRate, file2.AudioProperties.SampleRate);
158-
Assert.AreEqual (originalChannels, file2.AudioProperties.Channels);
157+
Assert.AreEqual (originalSampleRate, file2.Properties.SampleRate);
158+
Assert.AreEqual (originalChannels, file2.Properties.Channels);
159159
Assert.AreEqual ("Modified Title", file2.Tag.Title);
160160
}
161161

tests/TagLibSharp2.Tests/Asf/AsfFileTests.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,8 @@ public void Parse_ExtractsDuration ()
9393

9494
Assert.IsTrue (result.IsSuccess);
9595
// Duration should be approximately 180 seconds
96-
Assert.IsTrue (result.File!.AudioProperties.Duration.TotalSeconds >= 170);
97-
Assert.IsTrue (result.File!.AudioProperties.Duration.TotalSeconds <= 190);
96+
Assert.IsTrue (result.File!.Properties.Duration.TotalSeconds >= 170);
97+
Assert.IsTrue (result.File!.Properties.Duration.TotalSeconds <= 190);
9898
}
9999

100100
[TestMethod]
@@ -105,7 +105,7 @@ public void Parse_ExtractsBitrate ()
105105
var result = AsfFile.Read (data);
106106

107107
Assert.IsTrue (result.IsSuccess);
108-
Assert.AreEqual (320, result.File!.AudioProperties.Bitrate);
108+
Assert.AreEqual (320, result.File!.Properties.Bitrate);
109109
}
110110

111111
[TestMethod]
@@ -116,7 +116,7 @@ public void Parse_ExtractsSampleRate ()
116116
var result = AsfFile.Read (data);
117117

118118
Assert.IsTrue (result.IsSuccess);
119-
Assert.AreEqual (48000, result.File!.AudioProperties.SampleRate);
119+
Assert.AreEqual (48000, result.File!.Properties.SampleRate);
120120
}
121121

122122
[TestMethod]
@@ -127,7 +127,7 @@ public void Parse_ExtractsChannels ()
127127
var result = AsfFile.Read (data);
128128

129129
Assert.IsTrue (result.IsSuccess);
130-
Assert.AreEqual (2, result.File!.AudioProperties.Channels);
130+
Assert.AreEqual (2, result.File!.Properties.Channels);
131131
}
132132

133133
[TestMethod]
@@ -138,7 +138,7 @@ public void Parse_ExtractsBitsPerSample ()
138138
var result = AsfFile.Read (data);
139139

140140
Assert.IsTrue (result.IsSuccess);
141-
Assert.AreEqual (16, result.File!.AudioProperties.BitsPerSample);
141+
Assert.AreEqual (16, result.File!.Properties.BitsPerSample);
142142
}
143143

144144
// ═══════════════════════════════════════════════════════════════

tests/TagLibSharp2.Tests/Asf/AsfFileWriteTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -148,14 +148,14 @@ public void Render_PreservesDuration ()
148148
var data = AsfTestBuilder.CreateMinimalWma (durationMs: 180000);
149149
var result = AsfFile.Read (data);
150150
Assert.IsTrue (result.IsSuccess);
151-
var originalDuration = result.File!.AudioProperties.Duration;
151+
var originalDuration = result.File!.Properties.Duration;
152152

153153
result.File!.Title = "Changed";
154154
var rendered = result.File!.Render (data);
155155
var reparsed = AsfFile.Read (rendered);
156156

157157
Assert.IsTrue (reparsed.IsSuccess);
158-
Assert.AreEqual (originalDuration, reparsed.File!.AudioProperties.Duration);
158+
Assert.AreEqual (originalDuration, reparsed.File!.Properties.Duration);
159159
}
160160

161161
[TestMethod]
@@ -170,7 +170,7 @@ public void Render_PreservesSampleRate ()
170170
var reparsed = AsfFile.Read (rendered);
171171

172172
Assert.IsTrue (reparsed.IsSuccess);
173-
Assert.AreEqual (48000, reparsed.File!.AudioProperties.SampleRate);
173+
Assert.AreEqual (48000, reparsed.File!.Properties.SampleRate);
174174
}
175175

176176
[TestMethod]
@@ -185,7 +185,7 @@ public void Render_PreservesChannels ()
185185
var reparsed = AsfFile.Read (rendered);
186186

187187
Assert.IsTrue (reparsed.IsSuccess);
188-
Assert.AreEqual (2, reparsed.File!.AudioProperties.Channels);
188+
Assert.AreEqual (2, reparsed.File!.Properties.Channels);
189189
}
190190

191191
// ═══════════════════════════════════════════════════════════════

0 commit comments

Comments
 (0)