Add extra field to command struct and tests

Author: Sef

rpc/jsonrpc/types/walletsvrcmds.go

@@ -834,10 +834,11 @@ func NewSendManyCmd(fromAccount string, amounts map[string]float64, minConf *int
 
 // SendToAddressCmd defines the sendtoaddress JSON-RPC command.
 type SendToAddressCmd struct {
-	Address   string
-	Amount    float64
-	Comment   *string
-	CommentTo *string
+	Address               string
+	Amount                float64
+	Comment               *string
+	CommentTo             *string
+	SubtractFeeFromAmount *bool
 }
 
 // NewSendToAddressCmd returns a new instance which can be used to issue a

rpc/jsonrpc/types/walletsvrcmds_test.go

@@ -973,6 +973,26 @@ func TestWalletSvrCmds(t *testing.T) {
 				CommentTo: dcrjson.String("commentto"),
 			},
 		},
+		{
+			name: "sendtoaddress optional2",
+			newCmd: func() (interface{}, error) {
+				return dcrjson.NewCmd("sendtoaddress", "1Address", 0.5, "comment", "commentto", dcrjson.Bool(true))
+			},
+			staticCmd: func() interface{} {
+				val := NewSendToAddressCmd("1Address", 0.5, dcrjson.String("comment"),
+					dcrjson.String("commentto"))
+				val.SubtractFeeFromAmount = dcrjson.Bool(true)
+				return val
+			},
+			marshalled: `{"jsonrpc":"1.0","method":"sendtoaddress","params":["1Address",0.5,"comment","commentto",true],"id":1}`,
+			unmarshalled: &SendToAddressCmd{
+				Address:               "1Address",
+				Amount:                0.5,
+				Comment:               dcrjson.String("comment"),
+				CommentTo:             dcrjson.String("commentto"),
+				SubtractFeeFromAmount: dcrjson.Bool(true),
+			},
+		},
 		{
 			name: "settxfee",
 			newCmd: func() (interface{}, error) {

rpc/legacyrpc/methods.go

@@ -34,6 +34,7 @@ import (
 	"github.com/decred/dcrwallet/p2p"
 	"github.com/decred/dcrwallet/rpc/jsonrpc/types"
 	ver "github.com/decred/dcrwallet/version"
+	"github.com/decred/dcrwallet/wallet/v2"
 	"github.com/decred/dcrwallet/wallet/v2/txrules"
 	"github.com/decred/dcrwallet/wallet/v2/udb"
 )