Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/eth: Add jwt secret config option. #1956

Closed
JoeGruffins opened this issue Nov 11, 2022 · 3 comments · Fixed by #1963
Closed

client/eth: Add jwt secret config option. #1956

JoeGruffins opened this issue Nov 11, 2022 · 3 comments · Fixed by #1963
Assignees

Comments

@JoeGruffins
Copy link
Member

This may be a recent change, but geth now requires a secret to be communicated to use over http. It looks like a random 32 byte hex is fine, as that is what prysm and geth will use for authentication. We need to it to be a new config option and need to add one to the simnet harness and startup script.

https://github.com/ethereum/go-ethereum/blob/master/node/jwt_handler.go

Let me know if I am missing something, I don't think this was mentioned when the providers were added. Maybe it's just new to geth. A full node should work fine as a provider correct?

@JoeGruffins
Copy link
Member Author

I can add this.

@chappjc
Copy link
Member

chappjc commented Nov 11, 2022

Thanks @JoeGruffins. This will be good on server too so geth doesn't need to run on the same machine.

I think http has always required a token, but we've used IPC.

@JoeGruffins
Copy link
Member Author

Oh, that's right, we can point the clients to the IPC file. I suppose this may be more useful for the server then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants