Open
Conversation
Collaborator
Author
|
If the new look is okay, I'm suggesting removing this line since it will look redundant? dcrdata/cmd/dcrdata/views/visualblocks.tmpl Line 244 in 36ec508 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
This diff modifies the
/visualblockspage to match other pages that display block information e.g(/blocks,/months,/windowsetc) and includes a link to the/visualblockspage in all relevant pages. Closes #1940TODO: @chappjc, I'm thinking it would make sense to display for older blocks too(i.e not limiting to only recent/30 blocks max). Each page could display up to 10 blocks(including mempool block) with the option for viewers to visit pages with older blocks. what do you think?