Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use the Community Bubble instead of the custom Discord bubble #453

Merged
merged 10 commits into from
Jan 25, 2024
Merged

fix: Use the Community Bubble instead of the custom Discord bubble #453

merged 10 commits into from
Jan 25, 2024

Conversation

LautaroPetaccio
Copy link
Contributor

Screenshot 2024-01-19 at 09 55 26

@github-actions GitHub Actions
Copy link

Test this pull request

This branch can be previewed at

meelrossi
meelrossi reviewed Jan 24, 2024
View reviewed changes
package.json Outdated
@@ -34,6 +34,8 @@
]
},
"dependencies": {
"@0xsquid/sdk": "^2.8.9",
"@0xsquid/squid-types": "^0.1.51",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be on dev dependencies

package.json Outdated
@@ -34,6 +34,8 @@
]
},
"dependencies": {
"@0xsquid/sdk": "^2.8.9",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this being used?

@LautaroPetaccio LautaroPetaccio merged commit 1213873 into main Jan 25, 2024
3 checks passed
@LautaroPetaccio LautaroPetaccio deleted the fix/use-community-bubble branch January 25, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meelrossi meelrossi meelrossi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LautaroPetaccio @meelrossi