Fix(#7414): Fix React's bad setState() call warnings#7416
Open
fgnass wants to merge 4 commits intodecaporg:mainfrom
Open
Fix(#7414): Fix React's bad setState() call warnings#7416fgnass wants to merge 4 commits intodecaporg:mainfrom
fgnass wants to merge 4 commits intodecaporg:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the warnings React logs to the console when an asset preview is shown for the first time (see #7414).
The issue is caused because
getAssetdispatches an action, which in turn triggers a state update. I haven't done any Redux in a while, so there might be better patterns to fix this, but this at least does the trick.While fixing this, I stumbled over two other problems in the console logs:
ObjectPreview.field: This is declared asNode, but in reality an immutable map is passed.visualEditingis turned on. I filed this as Error: Visual editing breaks image previews #7415 and included a quick fix here that simply disables visualEditing for the posts collection indev-test.