Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search response #302

Open
erquhart opened this issue Mar 18, 2017 · 12 comments
Open

Improve search response #302

erquhart opened this issue Mar 18, 2017 · 12 comments

Comments

@erquhart
Copy link
Contributor

erquhart commented Mar 18, 2017

Requirements

  • A limited number of results appear in a dropdown directly beneath the search input while typing
  • Pressing enter takes you to a full results view
@erquhart erquhart added this to the 1.0 milestone Mar 20, 2017
@erquhart erquhart removed this from the 1.0 milestone Jun 27, 2017
@erquhart erquhart added this to the 1.0.0 milestone Sep 8, 2017
@erquhart erquhart closed this as completed Dec 8, 2017
@tech4him1
Copy link
Contributor

@erquhart Can you explain why this was closed? I still think it is unclear that you have to push enter to search.

@erquhart erquhart reopened this Dec 9, 2017
@erquhart
Copy link
Contributor Author

erquhart commented Dec 9, 2017

Busted. Maybe we just shouldn't have an enter button at all, just a 1 second debounce (in case an integration is in use).

@tech4him1
Copy link
Contributor

tech4him1 commented Dec 9, 2017

I would be fine with an instant search like you mentioned, because of the small usable space we have, although I still think that is less clear.

@erquhart
Copy link
Contributor Author

Ideally I think it would look like this for all backends:

  • A limited number of results appear in a dropdown directly beneath the search input while typing
  • Pressing enter or clicking submit takes you to a full results view

@erquhart erquhart removed this from the 1.0.0 milestone Dec 19, 2017
@erquhart erquhart removed the claimed label Apr 2, 2018
@erquhart erquhart removed their assignment Apr 2, 2018
@mittalyashu
Copy link
Contributor

Use the standard button from React Toolbox

What's React Toolbox?

@erquhart
Copy link
Contributor Author

erquhart commented Sep 4, 2018

That's an old comment, we used to use a library called React Toolbox but it was removed in 1.0.

@mittalyashu
Copy link
Contributor

Why we need a "Search" button?

Even the GitHub doesn't have a search button.

2018-09-04_23-39-22

@erquhart
Copy link
Contributor Author

erquhart commented Sep 4, 2018

Many interfaces don't, it's a fair point.

@tech4him1
Copy link
Contributor

I think we should have one of two things here:

  • Instant search
  • A search button

Right now, if I go to type in the search box and don't think to press "Enter", I get nothing: no feedback at all on what do do.

@mittalyashu
Copy link
Contributor

I agree with @tech4him1, we should go for instant search instead of a search button. As every user want the information ASAP, without doing much work and that's why instant search will be more useful.

As we are discussing search, how about we add Algolia, where users can add API keys and search bar will be replaced with Algolia search bar. Where users can not only search the title, but also the content inside each post.

@erquhart
Copy link
Contributor Author

erquhart commented Sep 5, 2018

Instant search is a more intuitive approach. Submission is implicit, which is why I created this issue in the first place, but it's a common enough pattern that it shouldn't be a problem.

There's a custom Algolia integration already in the CMS, it just isn't a public feature yet. That's pending backend/integration API redesign work that's currently underway.

@stale
Copy link

stale bot commented Oct 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale label Oct 29, 2019
@erquhart erquhart changed the title Add a submit button to the search bar Improve search response Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants