Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post listing grid view boxes too big #1341

Open
marvinkome opened this issue May 7, 2018 · 16 comments
Open

Post listing grid view boxes too big #1341

marvinkome opened this issue May 7, 2018 · 16 comments

Comments

@marvinkome
Copy link

- Do you want to request a feature or report a bug?
Feature

- What is the current behaviour?
Grid boxes for post listing are too big if they only display title

- If the current behaviour is a bug, please provide the steps to reproduce.

- What is the expected behaviour?
Boxes should add more information about the post or become smaller

@erquhart
Copy link
Contributor

Yeah, they were never supposed to stay that way, more info should definitely be shown in the grid boxes - same goes for list view, too.

@marvinkome
Copy link
Author

What info should be there. I can pick it up (I mean make a PR)

@erquhart
Copy link
Contributor

Awesome! We still need design, so I'm not certain this is ready to roll, but feel free to take a swing. We'll want to use inferred fields, which try to smartly determine things like author, date, etc, for each entry.

There's a set of constants that show what fields are being inferred, and you can see how inferred fields are already used to get the entry title here:

https://github.com/netlify/netlify-cms/blob/1d4162050956a25437882f2423f5b74a68c1c926/src/components/Collection/Entries/EntryCard.js#L22

@marvinkome
Copy link
Author

Is there a structure of how it should be displayed and what content should be inside? Also, the inferred constants don't have a date field, that would be useful in the boxes.

@erquhart
Copy link
Contributor

Is there a structure of how it should be displayed and what content should be inside?

That's why I mentioned the need for design here. As far as what to display, I'd just go with the available inferred fields, namely author, description, and image.

Also, the inferred constants don't have a date field, that would be useful in the boxes.

Agreed, but I'd recommend opening a separate issue and handling that in a different PR to keep this moving. Determining what fields to infer the date from and how best to display it would slow this PR down unnecessarily.

@mittalyashu
Copy link
Contributor

As far as what to display, I'd just go with the available inferred fields, namely author, description, and image.

Showing image in that small box would be hard, according to design.

image

We can show content like text or avatar image.

@erquhart
Copy link
Contributor

erquhart commented Sep 4, 2018

See old grid card design with images here: https://0-7-6--cms-demo.netlify.com/#/collections/posts

@mittalyashu
Copy link
Contributor

According to this design

image

We have:

  1. Image (media uploader widget)
  2. Title (string widget)
  3. Date (date widget)
  4. Body (markdown widget)

and sometimes a user might add more widgets to the collection and showing all the content on the gird can get messy.

Is there some rules or prioritization for NetlifyCMS that only selected content will be shown?

@erquhart
Copy link
Contributor

erquhart commented Sep 4, 2018

No, back then we just showed everything but cut off the overflow.

@mittalyashu
Copy link
Contributor

mittalyashu commented Sep 5, 2018

we just showed everything but cut off the overflow.

Hmm... 🤔

What if we design every element which will be shown on the grid or list view, but we will add the option where users can select which content they want to see, the same concept can be used for list and grid view.

@erquhart
Copy link
Contributor

erquhart commented Sep 5, 2018

That's always been the plan, just hasn't been a priority.

@charlie-s
Copy link

charlie-s commented Jan 23, 2019

Anyone working on this? Would really like to see image preview in my collections. Happy to contribute.

@tomrutgers
Copy link
Contributor

It's currently not claimed by anyone

@erquhart
Copy link
Contributor

erquhart commented Feb 1, 2019

@charlie-s we'd love the contribution - comment here or in Gitter if you have any questions while checking this out.

@stale
Copy link

stale bot commented Oct 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@coldice
Copy link

coldice commented Nov 24, 2019

Following up on @mittalyashu comment, how about just a list of field names to be shown? Or has this box more config options already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants