Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: remove DEBUG_FD #386

Closed
TooTallNate opened this issue Dec 20, 2016 · 6 comments
Closed

Proposal: remove DEBUG_FD #386

TooTallNate opened this issue Dec 20, 2016 · 6 comments

Comments

@TooTallNate
Copy link
Contributor

I implemented it a while ago, but personally have never needed to use it. Does anybody else use it?

Removing support for DEBUG_FD seems like it would be the simplest way to fix #280, since that's the only place where SyncWriteStream is used.
@thebigredgeek
Copy link
Contributor

I think that's fine. Doesn't really seem like this many configuration opens should be provided anyway. The API should be simple while also extensible

@TooTallNate
Copy link
Contributor Author

There is this part in the README:

Note: Certain IDEs (such as WebStorm) don't support colors on stderr. In these cases you must set DEBUG_COLORS to 1 and additionally change DEBUG_FD to 1.

But seems like more of a WebStorm issue IMO.

@thebigredgeek
Copy link
Contributor

Yeah agreed. And in this case I am not sure how many of our users actually use webstorm. Wish there were metrics haha

@thebigredgeek
Copy link
Contributor

We should probably move this here

@TooTallNate
Copy link
Contributor Author

Removal should go into v3, and we should have a deprecation warning in a v2 release to let anyone potentially using the env var to stop or speak up.

@thebigredgeek
Copy link
Contributor

@TooTallNate you wanna add the warning? Creating a v3 branch now

TooTallNate added a commit that referenced this issue Dec 27, 2016
@TooTallNate
remove DEBUG_FD
6b5ae03 
Now simply uses `process.stderr`. Breaking API change,
for the v3 branch.

Previously used internal and undocumented Node.js APIs to support
this underly used API.

Fixes #280
Closes #386
This was referenced Dec 28, 2016
Merged
Merged
thebigredgeek pushed a commit that referenced this issue Dec 28, 2016
@TooTallNate @thebigredgeek
Remove DEBUG_FD (#406)
dade81d 
* remove DEBUG_FD

Now simply uses `process.stderr`. Breaking API change,
for the v3 branch.

Previously used internal and undocumented Node.js APIs to support
this underly used API.

Fixes #280
Closes #386

* remove DEBUG_FD from readme
thebigredgeek pushed a commit that referenced this issue Apr 12, 2017
@TooTallNate @thebigredgeek
Remove DEBUG_FD (#406)
c9ff8e7 
* remove DEBUG_FD

Now simply uses `process.stderr`. Breaking API change,
for the v3 branch.

Previously used internal and undocumented Node.js APIs to support
this underly used API.

Fixes #280
Closes #386

* remove DEBUG_FD from readme
TooTallNate added a commit that referenced this issue Aug 8, 2017
@TooTallNate
Remove DEBUG_FD (#406)
56ba594 
* remove DEBUG_FD

Now simply uses `process.stderr`. Breaking API change,
for the v3 branch.

Previously used internal and undocumented Node.js APIs to support
this underly used API.

Fixes #280
Closes #386

* remove DEBUG_FD from readme
TooTallNate added a commit that referenced this issue Aug 8, 2017
@TooTallNate
Remove DEBUG_FD (#406)
ff432e7 
* remove DEBUG_FD

Now simply uses `process.stderr`. Breaking API change,
for the v3 branch.

Previously used internal and undocumented Node.js APIs to support
this underly used API.

Fixes #280
Closes #386

* remove DEBUG_FD from readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TooTallNate @thebigredgeek