-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unknown unit: XRP #22
Comments
It works for me… Do any currency conversions work? If you machine is offline, it won't be able to get any exchange rates, so no currencies will be loaded. If you run Try |
Yeah, there are a lot of cryptocurrencies in the active_currencies.txt but the problem is same with other of them. So it has to be something general. See the log below.
|
Most likely updating the exchange rates failed. It's possible that cryptocompare.com was temporarily unavailable. Try |
Yeah, you are probably right, after Maybe It will be good to add more explanatory info in these cases, what do you think? (Data source is temporarily unavailable, or something. Unknown unit is very misleading) |
Thinking about it, the issue probably wasn't that the workflow couldn't connect to the service, but rather that an update of exchange rates simply wasn't due for a few hours. You were still working with data from v2, which doesn't support any cryptocurrencies except Bitcoin. The only time you'll ever have this issue is the first time you install v3.0 and after adding new active currencies. I'll add a command to manually force an update of the exchange rates. |
@deanishe |
This should work since version 3.0, right?
Problem: XRP unit (Ripple coin) is not recognized.
Steps to reproduce: try to convert 1 XRP to another currency, for example, USD
Expected behavior: Should print converted amount (like in the case of BTC)
The text was updated successfully, but these errors were encountered: