Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown unit: XRP #22

Closed
jukben opened this issue Jul 17, 2017 · 6 comments
Closed

Unknown unit: XRP #22

jukben opened this issue Jul 17, 2017 · 6 comments

Comments

@jukben
Copy link

jukben commented Jul 17, 2017

This should work since version 3.0, right?

Problem: XRP unit (Ripple coin) is not recognized.
Steps to reproduce: try to convert 1 XRP to another currency, for example, USD
Expected behavior: Should print converted amount (like in the case of BTC)

screen shot 2017-07-17 at 16 09 18

screen shot 2017-07-17 at 16 14 09

@deanishe
Copy link
Owner

It works for me…

Do any currency conversions work? If you machine is offline, it won't be able to get any exchange rates, so no currencies will be loaded.

If you run convinfo and then Edit Active Currencies, is XRP in the list?

Try conv workflow:openlog. Are there any error messages in the log? (This is not the same as Alfred's debugger.)

@jukben
Copy link
Author

jukben commented Jul 17, 2017

Yeah, there are a lot of cryptocurrencies in the active_currencies.txt but the problem is same with other of them. So it has to be something general. See the log below.

17:07:26 convert.py:294 CRITICAL invalid query (1 ZEC ): Unknown unit: ZEC
17:07:28 convert.py:294 CRITICAL invalid query (1 ): No units specified
17:07:31 convert.py:294 CRITICAL invalid query (1 AUR ): Unknown unit: AUR
17:07:33 convert.py:294 CRITICAL invalid query (1 AUR CZK): Unknown unit: AUR
17:07:36 convert.py:294 CRITICAL invalid query (1 BUT): Unknown unit: BUT
17:07:37 convert.py:302 CRITICAL No to_units (or defaults) for dimensionless
17:07:38 convert.py:302 CRITICAL No to_units (or defaults) for [currency]
17:07:39 convert.py:294 CRITICAL invalid query (1 ): No units specified
17:07:42 convert.py:294 CRITICAL invalid query (1 ETC ): Unknown unit: ETC
17:08:02 convert.py:294 CRITICAL invalid query (!): Start your query with a number
17:08:03 convert.py:294 CRITICAL invalid query (1 XRP c): Unknown unit: XRP
17:08:04 convert.py:294 CRITICAL invalid query (1 XRP ): Unknown unit: XRP
17:08:05 convert.py:294 CRITICAL invalid query (1 XRP CZK): Unknown unit: XRP
17:08:20 convert.py:294 CRITICAL invalid query (1 ): No units specified
17:08:23 convert.py:294 CRITICAL invalid query (1 DOGE ): Unknown unit: DOGE
17:08:24 convert.py:294 CRITICAL invalid query (1 DOGE c): Unknown unit: DOGE
17:08:25 convert.py:294 CRITICAL invalid query (1 DOGE czk): Unknown unit: DOGE
17:11:11 convert.py:294 CRITICAL invalid query (workflow:openlo): Start your query with a ```

I tried to remove the workflow and imported it again – the same issue.

@deanishe
Copy link
Owner

Most likely updating the exchange rates failed. It's possible that cryptocompare.com was temporarily unavailable.

Try conv workflow:delcache to remove any cached exchange rates, try another conversion (which will trigger an update), then check the log file for messages relating to updating the exchange rates.

@jukben
Copy link
Author

jukben commented Jul 18, 2017

Yeah, you are probably right, after conv workflow:delcache it's working now properly. Thanks for this piece of software. 👍

Maybe It will be good to add more explanatory info in these cases, what do you think? (Data source is temporarily unavailable, or something. Unknown unit is very misleading)

@deanishe
Copy link
Owner

Data source is temporarily unavailable

Thinking about it, the issue probably wasn't that the workflow couldn't connect to the service, but rather that an update of exchange rates simply wasn't due for a few hours. You were still working with data from v2, which doesn't support any cryptocurrencies except Bitcoin.

The only time you'll ever have this issue is the first time you install v3.0 and after adding new active currencies.

I'll add a command to manually force an update of the exchange rates.

@jukben
Copy link
Author

jukben commented Jul 19, 2017

@deanishe The only time you'll ever have this issue is the first time you install v3.0 and after adding new active currencies. Yeah, that's was actually my case. The readme for it will be great. Thanks again! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants