Skip to content

Commit be214e9

Browse files
authored
Switch to use <EuiSuperselect /> component to list docker registery in router deployment (caraml-dev#396)
* switch to use euisuperselect to list docker registery * Address review comments - remove extra space, fix indentation
1 parent 39865c0 commit be214e9

File tree

2 files changed

+10
-36
lines changed

2 files changed

+10
-36
lines changed
Lines changed: 9 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,14 @@
1-
import React, { useState } from "react";
2-
import { EuiButtonEmpty, EuiContextMenu, EuiPopover } from "@elastic/eui";
3-
import { flattenPanelTree } from "@caraml-dev/ui-lib";
1+
import { EuiSuperSelect } from "@elastic/eui";
42

53
export const DockerRegistryPopover = ({ value, registryOptions, onChange }) => {
6-
const [isOpen, setOpen] = useState(false);
7-
8-
const panels = flattenPanelTree({
9-
id: 0,
10-
items: registryOptions.map((registry) => ({
11-
name: registry.inputDisplay,
12-
value: registry.value,
13-
icon: "logoDocker",
14-
onClick: () => {
15-
togglePopover();
16-
onChange(registry.value);
17-
},
18-
})),
19-
});
20-
21-
const togglePopover = () => setOpen(!isOpen);
224

235
return (
24-
<EuiPopover
25-
button={
26-
<EuiButtonEmpty
27-
size="xs"
28-
iconType="arrowDown"
29-
iconSide="right"
30-
onClick={togglePopover}>
31-
{(registryOptions.find((o) => o.value === value) || {}).inputDisplay}
32-
</EuiButtonEmpty>
33-
}
34-
isOpen={isOpen}
35-
closePopover={togglePopover}
36-
panelPaddingSize="s">
37-
<EuiContextMenu initialPanelId={0} panels={panels} />
38-
</EuiPopover>
6+
<EuiSuperSelect
7+
fullWidth
8+
options={registryOptions}
9+
valueOfSelected={value}
10+
itemLayoutAlign="top"
11+
onChange={onChange}
12+
/>
3913
);
40-
};
14+
};

ui/src/components/form/docker_image_combo_box/SelectDockerImageComboBox.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import React from "react";
2-
import { DockerRegistryPopover } from "./DockerRegistryPopover";
32
import "./SelectDockerImageComboBox.scss";
43
import { EuiComboBoxSelect } from "../combo_box/EuiComboBoxSelect";
4+
import { DockerRegistryPopover } from "./DockerRegistryPopover";
55

66
const extractRegistry = (image, registries) => {
77
if (image) {

0 commit comments

Comments
 (0)