Skip to content

Commit 7f02c46

Browse files
Colin Ian Kingralfbaechle
authored andcommitted
MIPS: Octeon: Fix fall through on bar type OCTEON_DMA_BAR_TYPE_SMALL
Bar type OCTEON_DMA_BAR_TYPE_SMALL assigns lo and hi addresses and then falls through to OCTEON_DMA_BAR_TYPE_BIG that re-assignes lo and hi addresses with totally different values. Add a break so we don't fall through. Signed-off-by: Colin Ian King <colin.king@canonical.com> Acked-by: David Daney <ddaney@caviumnetworks.com> Cc: linux-mips@linux-mips.org Cc: linux-kernel@vger.kernel.org Patchwork: https://patchwork.linux-mips.org/patch/6529/ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
1 parent b616365 commit 7f02c46

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

arch/mips/pci/msi-octeon.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,7 @@ int arch_setup_msi_irq(struct pci_dev *dev, struct msi_desc *desc)
150150
msg.address_lo =
151151
((128ul << 20) + CVMX_PCI_MSI_RCV) & 0xffffffff;
152152
msg.address_hi = ((128ul << 20) + CVMX_PCI_MSI_RCV) >> 32;
153+
break;
153154
case OCTEON_DMA_BAR_TYPE_BIG:
154155
/* When using big bar, Bar 0 is based at 0 */
155156
msg.address_lo = (0 + CVMX_PCI_MSI_RCV) & 0xffffffff;

0 commit comments

Comments
 (0)