satisfy checkstyle

Author: osheroff

src/main/java/com/github/shyiko/mysql/binlog/BinaryLogClient.java

@@ -989,8 +989,9 @@ private void addGtidToSet(String gtid) {
 
     private void updateGtidSet(Event event) {
         synchronized (gtidSetAccessLock) {
-            if (gtidSet == null)
+            if (gtidSet == null) {
                 return;
+            }
         }
 
         EventHeader eventHeader = event.getHeader();
@@ -1008,7 +1009,7 @@ private void updateGtidSet(Event event) {
             case QUERY:
                 QueryEventData qed = (QueryEventData) unwrapEventData(event.getData());
                 String sql = qed.getSql();
-                if ( sql == null ) {
+                if (sql == null) {
                     break;
                 }
 
@@ -1022,6 +1023,7 @@ private void updateGtidSet(Event event) {
                     //auto-commit query, likely DDL
                     addGtidToSet(currentGtid);
                 }
+            default:
         }
     }
 

src/test/java/com/github/shyiko/mysql/binlog/BinaryLogClientGTIDIntegrationTest.java

@@ -1,6 +1,22 @@
+/*
+ * Copyright 2013 Stanley Shyiko
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package com.github.shyiko.mysql.binlog;
 
-import com.github.shyiko.mysql.binlog.event.*;
+import com.github.shyiko.mysql.binlog.event.XidEventData;
+import com.github.shyiko.mysql.binlog.event.QueryEventData;
 import com.github.shyiko.mysql.binlog.event.deserialization.EventDeserializer;
 import org.testng.annotations.AfterClass;
 import org.testng.annotations.BeforeClass;
@@ -15,6 +31,11 @@
 import static org.testng.Assert.assertNotEquals;
 import static org.testng.AssertJUnit.assertNotNull;
 
+/**
+ * MySQL replication stream client.
+ *
+ * @author <a href="mailto:stanley.shyiko@gmail.com">Stanley Shyiko</a>
+ */
 public class BinaryLogClientGTIDIntegrationTest extends BinaryLogClientIntegrationTest {
     private final Logger logger = Logger.getLogger(getClass().getSimpleName());
 
@@ -27,7 +48,7 @@ private void enableGTID() throws SQLException {
                 public void execute(Statement statement) throws SQLException {
                     ResultSet rs = statement.executeQuery("select @@GLOBAL.GTID_MODE as gtid_mode");
                     rs.next();
-                    if ( rs.getString("gtid_mode").equals("ON") ) {
+                    if ("ON".equals(rs.getString("gtid_mode"))) {
                         return;
                     }
 
@@ -86,7 +107,6 @@ public void execute(ResultSet rs) throws SQLException {
             }
         });
 
-
         EventDeserializer eventDeserializer = new EventDeserializer();
         try {
             client.disconnect();

src/test/java/com/github/shyiko/mysql/binlog/BinaryLogClientIntegrationTest.java

@@ -34,7 +34,6 @@
 import com.github.shyiko.mysql.binlog.network.AuthenticationException;
 import com.github.shyiko.mysql.binlog.network.ServerException;
 import com.github.shyiko.mysql.binlog.network.SocketFactory;
-import com.mysql.jdbc.jdbc2.optional.MysqlConnectionPoolDataSource;
 import org.mockito.InOrder;
 import org.testng.SkipException;
 import org.testng.annotations.AfterClass;
@@ -727,20 +726,6 @@ public EventHeaderV4 deserialize(ByteArrayInputStream inputStream) throws IOExce
         }));
     }
 
-    protected class QueryEventFailureSimulator extends QueryEventDataDeserializer {
-        private boolean failureSimulated;
-
-        @Override
-        public QueryEventData deserialize(ByteArrayInputStream inputStream) throws IOException {
-            QueryEventData eventData = super.deserialize(inputStream);
-            if (!failureSimulated) {
-                failureSimulated = true;
-                throw new SocketException();
-            }
-            return eventData;
-        }
-    }
-
     private void testCommunicationFailureInTheMiddleOfEventDataDeserialization(final IOException ex) throws Exception {
         EventDeserializer eventDeserializer = new EventDeserializer();
         eventDeserializer.setEventDataDeserializer(EventType.QUERY, new QueryEventFailureSimulator());
@@ -1103,8 +1088,9 @@ public void execute(Callback<Statement> callback, boolean autocommit) throws SQL
             Statement statement = connection.createStatement();
             try {
                 callback.execute(statement);
-                if ( !autocommit )
+                if (!autocommit) {
                     connection.commit();
+                }
             } finally {
                 statement.close();
             }
@@ -1166,4 +1152,22 @@ public interface Callback<T> {
 
         void execute(T obj) throws SQLException;
     }
+
+    /**
+     * @author <a href="mailto:stanley.shyiko@gmail.com">Stanley Shyiko</a>
+     */
+    protected class QueryEventFailureSimulator extends QueryEventDataDeserializer {
+        private boolean failureSimulated;
+
+        @Override
+        public QueryEventData deserialize(ByteArrayInputStream inputStream) throws IOException {
+            QueryEventData eventData = super.deserialize(inputStream);
+            if (!failureSimulated) {
+                failureSimulated = true;
+                throw new SocketException();
+            }
+            return eventData;
+        }
+    }
+
 }