This change set adds support for using http POST method to upload

userdata larger than 2K.

lib/cloudstack_ruby_client/base_client.rb
  If userdata is present and its size is larger than 2048 bytes in
  request params, switch to http POST method for current api call.

lib/cloudstack_ruby_client/client.rb
lib/cloudstack_ruby_client/client_helper.rb
  Trivial changes to use symbol as hash keys consistently.

Author: ypz

lib/cloudstack_ruby_client/base_client.rb

@@ -9,22 +9,34 @@ def initialize(api_url, api_key, secret_key, use_ssl=nil, open_timeout=20)
   end
 
   def request(params)
-    params['response'] = 'json'
-    params['apiKey'] = @api_key
-    
+    params[:response] = 'json'
+    params[:apiKey] = @api_key
+
     data = params.map{ |k,v| "#{k.to_s}=#{CGI.escape(v.to_s).gsub(/\+|\ /, "%20")}" }.sort.join('&')
-    
     signature = OpenSSL::HMAC.digest 'sha1', @secret_key, data.downcase
     signature = Base64.encode64(signature).chomp
-    signature = CGI.escape(signature)
 
-    url = "#{@api_url}?#{data}&signature=#{signature}"
+    method = 'POST' if params[:userdata] and params[:userdata].size > 2048
+    if method == "POST"
+      params[:signature] = signature
+      url = @api_url
+    else
+      signature = CGI.escape(signature)
+      url = "#{@api_url}?#{data}&signature=#{signature}"
+    end
+
     uri = URI.parse(url)
     http = Net::HTTP.new(uri.host, uri.port)
     http.use_ssl = @use_ssl
     http.open_timeout = @open_timeout  # fail the connection faster if can't open socket
     http.verify_mode = OpenSSL::SSL::VERIFY_NONE
-    request = Net::HTTP::Get.new(uri.request_uri)
+
+    if method == 'POST'
+      request = Net::HTTP::Post.new(uri.request_uri)
+      request.set_form_data(params)
+    else
+      request = Net::HTTP::Get.new(uri.request_uri)
+    end
 
     http.request(request)
   end

lib/cloudstack_ruby_client/client.rb

@@ -72,8 +72,8 @@ def wait_for_async_job(job, timeout=nil)
   protected
 
   def auth_request(params, command)
-    params['response'] = 'json'
-    params['command']  = command
+    params[:response] = 'json'
+    params[:command]  = command
     data = params.map{ |k,v| "#{k.to_s}=#{CGI.escape(v.to_s).gsub(/\+|\ /, "%20")}" }.sort.join('&')
 
     url = "#{@api_url}?#{data}"

lib/cloudstack_ruby_client/client_helper.rb

@@ -90,7 +90,7 @@ def #{arg}(args={});
       } +
 
       %Q{
-          params = {'command' => command};
+          params = {:command => command};
           params.merge!(args) unless args.empty?;
 
           response = request(params);