Raise ValueError in get_db_prep_value() when value is of invalid length #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
IMO a better approach would be to attempt to create an uuid.UUID instance which would raise exceptions automatically. All the checks are already present in the UUID class so there is no need to replicate these in the UUIDField. This also solves many other cases like non-hex characters in the string. |
| @@ -118,7 +118,9 @@ def get_db_prep_value(self, value, connection, prepared=False): | |||
| value = str(value) | |||
| if isinstance(value, str): | |||
| if '-' in value: | |||
| return value.replace('-', '') | |||
| value = value.replace('-', '') | |||
| if value and len(value) != 32: | |||
There was a problem hiding this comment.
It's better to try to load the value using uuid.UUID constructor, which may raise ValueError if the value is not valid. A defect here is that the condition does not exclude all invalid values. (as noted by @rychlis )
|
@rychlis Great idea! I will add this to the pull request. |
dcramer
added a commit
that referenced
this pull request
Jan 19, 2015
Raise ValueError in get_db_prep_value() when value is of invalid length
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46.